Hi,

I've made the following changes for bug 531 173 [1] :
a) Squash the commit
b) Reword the "squashed" with the changeId of the first push

I would like to know if I'm on the right way.

Thanks

Laurent


[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=531173

2018-02-21 18:19 GMT+01:00 Wim Jongman <wim.jong...@remainsoftware.com>:

> Hi Laurent,
>
>
>
> Yes, but make sure to use the changeid of the first change set.
>
>
>
> Cheers,
>
>
>
> Wim
>
>
>
> *From:* nebula-dev-boun...@eclipse.org [mailto:nebula-dev-bounces@
> eclipse.org] *On Behalf Of *Laurent Caron
> *Sent:* Wednesday, 21 February 2018 18:03
>
> *To:* Nebula Dev
> *Subject:* Re: [nebula-dev] Opal > Nebula; Balance of the week
>
>
>
> Hi,
>
> Thank you for answer.
>
> I did not work on the issues with the change set... If I understand well,
> I need to "squash" the commits (except the first I pushed), and amend last
> commit ?
>
>
>
> Thanks
>
> Laurent
>
>
>
>
>
> 2018-02-21 17:36 GMT+01:00 Wim Jongman <wim.jong...@remainsoftware.com>:
>
> Hi Laurent,
>
>
>
> We do not have a set process. Committers normally do this themselves.
> However, if you like me  to look at the code then just add me as a reviewer.
>
>
>
> Did you resolve the issues with all the different change sets?
>
>
>
> Cheers,
>
>
>
> wim
>
>
>
> *From:* nebula-dev-boun...@eclipse.org [mailto:nebula-dev-bounces@
> eclipse.org] *On Behalf Of *Laurent Caron
> *Sent:* Wednesday, 21 February 2018 17:26
> *To:* Nebula Dev
> *Subject:* Re: [nebula-dev] Opal > Nebula; Balance of the week
>
>
>
> Hi,
>
> The documentation on the wiki has been "upgraded" :
>
> - Additional link added on the top of the pages to go back to the main
> Nebula page
>
> - TOC added after the "introduction" section
>
> - Change URL for the link(s) to the snippets to make them shorter
>
> Now I would like to know how to process the next steps: I've got many
> branches pushed on Gerrit (one for Java 8 upgrade, others for new
> components).
>
> In my company, you can not merge a branch into master until 2 developpers
> have checked/reviewed the code.
>
> What is the policy on nebula project ?
>
> Thank you and hace a nice day,
>
> Laurent
>
>
>
>
>
>
>
>
>
> 2018-02-20 17:35 GMT+01:00 Laurent Caron <laurent.ca...@gmail.com>:
>
> Hi Wim,
>
> Thank you for your encouragements :)
>
> I've noticed your change, and I moved the TOC on all other pages (it's a
> good idea !)
>
>
> I will format the links at the end of pages this evening
> .
>
> Cheers,
>
> Laurent
>
>
>
>
>
> 2018-02-19 8:44 GMT+01:00 Wim Jongman <wim.jong...@gmail.com>:
>
> Hi Laurent,
>
> You are on a roll. Fantastic work.
>
> I have updated one of your wiki pages a bit [1]:
>
> * The TOC is moved below the short widget introduction
>
> * The Snippet links below are formatted to not show the complete link.
>
> Let me know what you think of these changes so that we can do the other
> widgets as well.
>
>
>
> [1] https://wiki.eclipse.org/Nebula_PropertyTable
>
>
>
>
>
> On Sat, Feb 17, 2018 at 11:25 PM, Laurent Caron <laurent.ca...@gmail.com>
> wrote:
>
> Good evening,
>
> Once again, Wim (aka Clark Kent) helped me a lot this week.
>
> What has been done :
>
> - The Nebula website [1] has been updatedé
>
> - A new widget called *Rounded toolbar* has been added [2] and upgraded
> [3] (an issue was open on github a few days before the merge)
>
> - The whole documentation has been migrated from Github to Eclipse
>
> Work in progress, waiting for review :
>
> - Add Opal Calculator [4] to Nebula
>
> - Upgrade Opal To Java 8 [5]
>
>
>
> Next Steps:
>
> - Add new widgets; Horizontal Spinner, Launcher, Panels and Switch Button
> [6-9]
>
> - Upgrade documentation
>
>
>
> Have a nice evening and a nice sunday,
>
> Laurent
>
>
>
> -----
> [1] https://www.eclipse.org/nebula/
> [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=531068
>
> [3] https://bugs.eclipse.org/bugs/show_bug.cgi?id=531021
>
> [4] https://bugs.eclipse.org/bugs/show_bug.cgi?id=531173
> [5] https://bugs.eclipse.org/bugs/show_bug.cgi?id=530974
> [6] https://bugs.eclipse.org/bugs/show_bug.cgi?id=531174
> [7] https://bugs.eclipse.org/bugs/show_bug.cgi?id=531175
> [8] https://bugs.eclipse.org/bugs/show_bug.cgi?id=531176
> [9] https://bugs.eclipse.org/bugs/show_bug.cgi?id=531177
>
>
>
> _______________________________________________
> nebula-dev mailing list
> nebula-dev@eclipse.org
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://dev.eclipse.org/mailman/listinfo/nebula-dev
>
>
>
>
> _______________________________________________
> nebula-dev mailing list
> nebula-dev@eclipse.org
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://dev.eclipse.org/mailman/listinfo/nebula-dev
>
>
>
>
>
>
> _______________________________________________
> nebula-dev mailing list
> nebula-dev@eclipse.org
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://dev.eclipse.org/mailman/listinfo/nebula-dev
>
>
>
> _______________________________________________
> nebula-dev mailing list
> nebula-dev@eclipse.org
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://dev.eclipse.org/mailman/listinfo/nebula-dev
>
_______________________________________________
nebula-dev mailing list
nebula-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/nebula-dev

Reply via email to