Woot! Works very very nice. Thanks for your time Jonah!! On Thu, Aug 16, 2018 at 2:25 PM Jonah Graham <[email protected]> wrote:
> Hi folks, > > I have created new jobs that use the GitHub PR Builder on Jenkins for > stable[1] and incubation[2]. These builders will report back to the PR, > meaning each PR should have 3 checks run, the two builds, plus the IP check > (screenshot from [3]): > > [image: image.png] > > The PR builds do not use the "build-server" profile, therefore they run > much faster, but they are not signed or pack200'd. > > All member of the Eclipse organisation[4] should have their PRs built > automatically as the whole organisation is on the whitelist. All other PRs > need to be approved before they are built for the first time. To approve a > PR you have to be an admin and say: > > - "ok to test" to accept this pull request for testing > - "test this please" for a one time test run > - "add to whitelist" to add the author to the whitelist > > If the build fails for other various reasons you can rebuild. > > - "retest this please" to start a new build > > See full documentation for more info[5] > > All committers can be admins, simply add yourself to the list ([1,2] -> > Configuration -> Build Triggers -> GitHub Pull Request Builder -> Admin > list). I have added Wim and myself so far. > > *Note that Jenkins polls at 5 minute intervals, so there will be a delay > between a PR being submitted and the build starting. There are security > considerations for allowing webhooks[6].* > > Please let me know if you see anything amiss. > > Jonah > > > [1] https://ci.eclipse.org/nebula/job/nebula.stable.github/ > [2] https://ci.eclipse.org/nebula/job/nebula.incubation.github/ > [3] https://github.com/eclipse/nebula/pull/5 > [4] https://github.com/orgs/eclipse/people > [5] > https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin > [6] https://bugs.eclipse.org/bugs/show_bug.cgi?id=537191#c15 > > ~~~ > Jonah Graham > Kichwa Coders Ltd. > www.kichwacoders.com > > > On Tue, 7 Aug 2018 at 08:30, Jonah Graham <[email protected]> wrote: > >> I made the request for the plugin on the bug ( >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=537191) >> >> I'll make some updates to Wiki regarding bug trackers. >> >> Jonah >> >> On Mon, 6 Aug 2018, 22:55 Wim Jongman, <[email protected]> wrote: >> >>> I seem to have mixed up hudson and jenkins. It is jenkins we are using >>> and therefore the plugin should be available according to 534546 or maybe >>> we need to just request it. >>> >>> Cheers >>> >>> On Mon, Aug 6, 2018 at 11:43 PM Wim Jongman <[email protected]> >>> wrote: >>> >>>> Hey Jonah, >>>> >>>> I have found this plugin as well but I saw it was not implemented in >>>> Hudson. After searching eclipse [1] I implemented the suggestions found in >>>> bug 439145 [2] just to get a minimal end-to-end workflow. Your request >>>> seems to have already been implemented recently for jenkins [3] but since >>>> then we have moved to Hudson. >>>> >>>> Please go ahead and see if you can get something rolling for hudson as >>>> well. I assume you have full access to our hudson jobs? [4] >>>> >>>> Cheers, >>>> >>>> Wim >>>> >>>> [1] https://www.eclipse.org/home/search.php?q=github%20pull%20requests >>>> [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=439145 >>>> [3] https://bugs.eclipse.org/bugs/show_bug.cgi?id=534546 >>>> [4] https://wiki.eclipse.org/Nebula/Builds >>>> >>>> >>>> On Mon, Aug 6, 2018 at 9:02 PM Jonah Graham <[email protected]> >>>> wrote: >>>> >>>>> Hi Wim, >>>>> >>>>> I was going to do the incubation builds for GitHub, but I noticed that >>>>> my PR for Nebula did not actually generate a confirmation/tick back to >>>>> GitHub. I asked on cbi-dev[1] what the best approach for doing PR builds >>>>> is. Had you considered using the GitHub PR Builder plug-in[2] for this? >>>>> >>>>> if you don't have an objection, I would like to request the plug-in be >>>>> added to Nebula's Jenkins and the jobs be configured to contribute a score >>>>> back to GitHub. >>>>> >>>>> Thanks >>>>> Jonah >>>>> >>>>> [1] https://dev.eclipse.org/mhonarc/lists/cbi-dev/msg01940.html >>>>> [2] >>>>> https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin >>>>> >>>>> ~~~ >>>>> Jonah Graham >>>>> Kichwa Coders Ltd. >>>>> www.kichwacoders.com >>>>> >>>>> >>>>> On Mon, 6 Aug 2018 at 18:25, Jonah Graham <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi Wim, >>>>>> >>>>>> Thanks. I suspect I have tracked down the problem. I changed github >>>>>> IDs a while ago and the github based Eclipse projects I was already part >>>>>> of >>>>>> updated fine, but this new one didn't work. I'll wait for the overnight >>>>>> sync and raise an issue with webmaster tomorrow if I still have access >>>>>> issues. >>>>>> >>>>>> PS I also submitted https://git.eclipse.org/r/#/c/127101/ to update >>>>>> Oomph to point to the github location for the setup file. >>>>>> >>>>>> Jonah >>>>>> >>>>>> ~~~ >>>>>> Jonah Graham >>>>>> Kichwa Coders Ltd. >>>>>> www.kichwacoders.com >>>>>> >>>>>> >>>>>> On Mon, 6 Aug 2018 at 17:43, Wim Jongman <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Thanks Jonah! >>>>>>> >>>>>>> For [5]. I'm sure I saw you in the list. Please check your eclipse >>>>>>> profile for the GitHub user. >>>>>>> >>>>>>> All, please update your eclipse profile and set your GitHub name. >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Mon, 6 Aug 2018, 16:25 Jonah Graham, <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi folks, >>>>>>>> >>>>>>>> I have updated the main Nebula Contributing Wiki pages[0, 1, 2, 3], >>>>>>>> updated the Oomph and Team Project Set files (PR pending[4], I don't >>>>>>>> seem >>>>>>>> to be able to approve/merge the PR as I don't seem to be in the GitHub >>>>>>>> team >>>>>>>> and I didn't get a github invitation [5]). >>>>>>>> >>>>>>>> My Wiki updates includes a few other minor updates, for example >>>>>>>> calling it ECA (instead of CLA), links to Jenkins (ci.eclipse.org >>>>>>>> instead of hudson.eclipse.org). >>>>>>>> >>>>>>>> I have also assumed the new job for github PRs for incubation will >>>>>>>> be: >>>>>>>> https://ci.eclipse.org/nebula/job/nebula.incubation.pullrequests/ (if >>>>>>>> not, update [6]) >>>>>>>> >>>>>>>> HTH, >>>>>>>> Jonah >>>>>>>> >>>>>>>> [0] https://wiki.eclipse.org/Nebula/Contributions >>>>>>>> [1] https://wiki.eclipse.org/Nebula/Builds >>>>>>>> [2] https://wiki.eclipse.org/Nebula/Contributions/New_Widgets >>>>>>>> [3] https://wiki.eclipse.org/Nebula/Contributions/Setup_IDE >>>>>>>> [4] https://github.com/eclipse/nebula/pull/2 >>>>>>>> [5] https://github.com/orgs/eclipse/teams/eclipse-nebula (you >>>>>>>> can't actually see this unless you are in the team) >>>>>>>> [6] >>>>>>>> https://wiki.eclipse.org/Nebula/Contributions#Building_on_our_build_server >>>>>>>> ~~~ >>>>>>>> Jonah Graham >>>>>>>> Kichwa Coders Ltd. >>>>>>>> www.kichwacoders.com >>>>>>>> >>>>>>>> >>>>>>>> On Mon, 6 Aug 2018 at 13:39, Jonah Graham <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi Wim, >>>>>>>>> >>>>>>>>> Thanks for this. I am now working on updating [3]. I do have some >>>>>>>>> questions: >>>>>>>>> >>>>>>>>> - is the project continuing to use Bugzilla, or are we migrating >>>>>>>>> to GitHub Issues too. The bug [2] doesn't say either way. I believe >>>>>>>>> if you >>>>>>>>> have access to Settings (which normal committers don't) you can just >>>>>>>>> turn >>>>>>>>> Issues off. There is an Eclipse bot that adds links to PRs if you >>>>>>>>> type Bug >>>>>>>>> 123456. >>>>>>>>> - In past experience setting up github projects at Eclipse the >>>>>>>>> branches were not protected by default, meaning any committer can >>>>>>>>> force >>>>>>>>> push to master. I recommend checking/requesting protected master >>>>>>>>> branch >>>>>>>>> status -- of course there are more options on protected branches that >>>>>>>>> can >>>>>>>>> be considered, like required PR reviews, passing CI checks, etc. >>>>>>>>> >>>>>>>>> [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=537191 >>>>>>>>> [3] https://wiki.eclipse.org/Nebula/Contributions >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> Jonah >>>>>>>>> >>>>>>>>> ~~~ >>>>>>>>> Jonah Graham >>>>>>>>> Kichwa Coders Ltd. >>>>>>>>> www.kichwacoders.com >>>>>>>>> >>>>>>>>> >>>>>>>>> On Mon, 6 Aug 2018 at 11:59, Wim Jongman <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> Our Github repo is live and we have received our first pull >>>>>>>>>> request for XViewer [0] >>>>>>>>>> >>>>>>>>>> I'm on vacation but I managed to get the main infrastructure >>>>>>>>>> running. >>>>>>>>>> >>>>>>>>>> * Main build [1] >>>>>>>>>> * Pull request build [2] >>>>>>>>>> >>>>>>>>>> The following things need to happen >>>>>>>>>> >>>>>>>>>> * Accept your github invitation >>>>>>>>>> * Update the incubation jobs the same way we did for the stable >>>>>>>>>> jobs* >>>>>>>>>> * Update our contribution guide [3] >>>>>>>>>> * Update our website >>>>>>>>>> >>>>>>>>>> If you want to work on any of these items, please go ahead. If >>>>>>>>>> you don't know how, or want to discuss: I am available to answer >>>>>>>>>> e-mails. >>>>>>>>>> >>>>>>>>>> Cheers, >>>>>>>>>> >>>>>>>>>> Wim >>>>>>>>>> >>>>>>>>>> [4] https://www.eclipse.org/nebula/ >>>>>>>>>> [3] https://wiki.eclipse.org/Nebula/Contributions >>>>>>>>>> [2] >>>>>>>>>> https://hudson.eclipse.org/nebula/job/nebula.stable.pullrequests/ >>>>>>>>>> [1] https://hudson.eclipse.org/nebula/job/nebula.stable/] >>>>>>>>>> [0] https://github.com/orgs/eclipse/teams/eclipse-nebula >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> * stable widgets are the ones that we release, incubation widgets >>>>>>>>>> are unstable or unmaintained. >>>>>>>>>> _______________________________________________ >>>>>>>>>> nebula-dev mailing list >>>>>>>>>> [email protected] >>>>>>>>>> To change your delivery options, retrieve your password, or >>>>>>>>>> unsubscribe from this list, visit >>>>>>>>>> https://dev.eclipse.org/mailman/listinfo/nebula-dev >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>> nebula-dev mailing list >>>>>>>> [email protected] >>>>>>>> To change your delivery options, retrieve your password, or >>>>>>>> unsubscribe from this list, visit >>>>>>>> https://dev.eclipse.org/mailman/listinfo/nebula-dev >>>>>>> >>>>>>> _______________________________________________ >>>>>>> nebula-dev mailing list >>>>>>> [email protected] >>>>>>> To change your delivery options, retrieve your password, or >>>>>>> unsubscribe from this list, visit >>>>>>> https://dev.eclipse.org/mailman/listinfo/nebula-dev >>>>>> >>>>>> _______________________________________________ >>>>> nebula-dev mailing list >>>>> [email protected] >>>>> To change your delivery options, retrieve your password, or >>>>> unsubscribe from this list, visit >>>>> https://dev.eclipse.org/mailman/listinfo/nebula-dev >>>> >>>> _______________________________________________ >>> nebula-dev mailing list >>> [email protected] >>> To change your delivery options, retrieve your password, or unsubscribe >>> from this list, visit >>> https://dev.eclipse.org/mailman/listinfo/nebula-dev >> >> _______________________________________________ > nebula-dev mailing list > [email protected] > To change your delivery options, retrieve your password, or unsubscribe > from this list, visit > https://dev.eclipse.org/mailman/listinfo/nebula-dev
_______________________________________________ nebula-dev mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/nebula-dev
