Hi, thanks for the patch release (2.4.1).

I tried it with our application.
Good news: the NPE in the CDateTime widget from 2.4.0 is fixed.
Bad news: another NPE occurs  in the CDateTime widget now when configuring
the fore ground color for the minutes in the picker (using the CSS-property
"cdt-picker-minutes-color"):

java.lang.NullPointerException: null
at
org.eclipse.nebula.widgets.cdatetime.CDateTime.setPickerMinutesColor(CDateTime.java:2404)
~[org.eclipse.nebula.widgets.cdatetime_1.4.0.202007101949.jar:na]
at
org.eclipse.nebula.widgets.cdatetime.css.CDateTimePropertyHandler.applyCSSProperty(CDateTimePropertyHandler.java:100)
~[org.eclipse.nebula.widgets.cdatetime.css_1.4.0.202007101949.jar:na]
at
org.eclipse.e4.ui.css.core.impl.engine.AbstractCSSEngine.applyCSSProperty(AbstractCSSEngine.java:726)
~[org.eclipse.e4.ui.css.core_0.12.700.v20190513-2118.jar:na]

Looks like there are usages of the picker instance still in the class that
are not checked for null...

Best,
  MP

P.S. Besides, should setting CDT.CLOCK_DISCRETE flag in the CDateTime
widget work in 2.4.1?
Regardless whether it is set in the constructor or not, I always get the
analog clock.

Am Do., 9. Juli 2020 um 22:58 Uhr schrieb Wim Jongman <wim.jong...@gmail.com
>:

> Hi Matthias,
>
> We (Laurent) already fixed this. I will make an intermediate 2.4.1 release
> for this issue ASAP.
>
> In the meantime you may use the snapshot build.
>
> Cheers,
>
> Wim
>
> On Thu, Jul 9, 2020, 4:51 PM Matthias Paul Scholz <
> matthias.paul.sch...@gmail.com> wrote:
>
>> Thanks for the new release and in particular  the theming support for
>> various widgets!
>>
>> Sadly, when switching to the 2.4 in our application (without changing any
>> code)  I instantly ran into a NullPointerException  in the CDateTime widget.
>>
>> Creating a CDateTime with
>>
>> new CDateTime(parent, getStyle() | CDT.DROP_DOWN  | CDT.DATE_MEDIUM |
>> CDT.TIME_MEDIUM | CDT.CLOCK_DISCRETE);
>>
>> (which worked with 2.3) led to
>>
>>  java.lang.NullPointerException
>> at
>> org.eclipse.nebula.widgets.cdatetime.CDateTime.setBackground(CDateTime.java:2245)
>> at
>> org.eclipse.e4.ui.css.swt.helpers.CSSSWTColorHelper.setBackground(CSSSWTColorHelper.java:360)
>> at
>> org.eclipse.e4.ui.css.swt.properties.css2.CSSPropertyBackgroundSWTHandler.applyCSSPropertyBackgroundColor(CSSPropertyBackgroundSWTHandler.java:80)
>>
>> Looks like the picker instance is always null when not using CDT.SIMPLE
>> ...
>>
>> Best,
>>   MP
>> _______________________________________________
>> nebula-dev mailing list
>> nebula-dev@eclipse.org
>> To unsubscribe from this list, visit
>> https://www.eclipse.org/mailman/listinfo/nebula-dev
>>
> _______________________________________________
> nebula-dev mailing list
> nebula-dev@eclipse.org
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/nebula-dev
>
_______________________________________________
nebula-dev mailing list
nebula-dev@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/nebula-dev

Reply via email to