Hi Nicolas,

I wonder if I might cheekily suggest some small changes to Neko's
Makefile so that make install behaves a bit more as Unix people
expect? The two issues I see are:

* Default installation to /usr, which is bad because the consensus is
that manual builds should go in /usr/local in order to avoid conflicts
with system package management. /usr/local is the default in almost
every other project for this reason.

* Development headers aren't installed by make install. This is bad
because it means that the headers have to either be installed
manually, or separate copies kept up to date within each Neko project.

Patch enclosed, although it's just as trivial as all my others ;)

Thanks,
Dan.
Index: Makefile
===================================================================
RCS file: /cvsroot/neko/Makefile,v
retrieving revision 1.63
diff -u -r1.63 Makefile
--- Makefile	15 Feb 2007 20:08:15 -0000	1.63
+++ Makefile	22 Apr 2007 14:17:58 -0000
@@ -1,6 +1,6 @@
 ## CONFIG
 
-INSTALL_PREFIX = /usr
+INSTALL_PREFIX = /usr/local
 
 CFLAGS = -Wall -O3 -fPIC -fomit-frame-pointer -I vm -DCOMPACT_TABLE
 EXTFLAGS = -pthread
@@ -128,11 +128,13 @@
 	rm -rf src/*.n src/neko/*.n src/nekoml/*.n src/tools/*.n
 	rm -rf bin/mtypes bin/tools
 
-install:	
+install:
 	cp bin/${LIBNEKO_NAME} ${INSTALL_PREFIX}/lib
 	cp bin/neko bin/nekoc bin/nekotools ${INSTALL_PREFIX}/bin
-	mkdir ${INSTALL_PREFIX}/lib/neko
+	-mkdir ${INSTALL_PREFIX}/lib/neko
 	cp bin/*.ndll ${INSTALL_PREFIX}/lib/neko
+	-mkdir ${INSTALL_PREFIX}/include	
+	cp vm/neko*.h ${INSTALL_PREFIX}/include
 
 uninstall:
 	rm -rf ${INSTALL_PREFIX}/lib/${LIBNEKO_NAME}
-- 
Neko : One VM to run them all
(http://nekovm.org)

Reply via email to