I have made the following changes intended for : CE:UX:MTF / meegotouchcp-datetime
Please review and accept ASAP - BOSS has already processed this request and suggests ??? See the "Messages from BOSS" section below https://build.pub.meego.com/request/show/2737 Thank You, bossbot ([email protected]) [This message was auto-generated] --- Request # 2737: Messages from BOSS: None State: new 2011-10-24T21:28:52 bossbot Reviews: from bossbot :BOSS suggests accepting this review. See email for more details. BOSS accepted this review because: Target repo CE_UX_MTF_armv7hl found. accepted on No date Changes: submit: Project:MTF / meegotouchcp-datetime -> CE:UX:MTF / meegotouchcp-datetime Index: meegotouchcp-datetime.yaml =================================================================== --- meegotouchcp-datetime.yaml (revision 0) +++ meegotouchcp-datetime.yaml (revision 10) @@ -0,0 +1,51 @@ +Name: meegotouchcp-datetime +Summary: MeeGo Language Settings +Version: 0.10.3 +Release: 1 +Group: Application Framework/MeeGo Touch Settings +License: LGPLv2.1 +URL: http://meego.gitorious.org/meegotouch/meegotouch-controlpaneldatetimeapplet +Sources: + - "%{name}-%{version}.tar.bz2" +Description: MeegoTouchControlPanel plugin to set date and time. +PkgConfigBR: + - QtGui + - icu-uc + - meegotouch + - meegotouch-controlpanel + - qmsystem2 +Requires: + - meegotouchcp-datetime-l10n-engineering-english = %{version} +Patches: + - BMC_16755_Meegotouchcp-datetime-tests_does_not_work_with_test_automation.patch + - meegotouchcp-datetime-0.10.3-timepicker-define.patch +Configure: none +Builder: qmake +SetupOptions: "-q -n %{name}-%{version}" +Files: + - "%{_libdir}/duicontrolpanel/*" + - "%{_datadir}/duicontrolpanel-datetimeapplet/*" + - "%{_datadir}/duicontrolpanel/desktops/datetime.desktop" + - "%{_datadir}/themes/base/meegotouch/libdatetimeapplet/style/libdatetimeapplet.css" + +SubPackages: + - Name: meegotouchcp-datetime-l10n-engineering-english + AsWholeName: True + Summary: Engineering English translations for the datetime applet + Group: System/Libraries + Files: + - "%{_datadir}/l10n/meegotouch/date-time.qm" + Description: | + Engineering English translations for the datetime applet + + - Name: meegotouchcp-datetime-tests + AsWholeName: True + Summary: meegotouchcp-datetime applet functional and unit tests + Group: System/Libraries + Files: + - "%{_libdir}/meegotouchcp-datetime-tests/*" + - "%{_datadir}/meegotouchcp-datetime-tests/*" + Requires: + - meegotouchcp-datetime = %{version} + Description: | + Functional and Unit testing binaries and shellscripts for testing meegotouchcp-datetime applet Index: meegotouchcp-datetime.changes =================================================================== --- meegotouchcp-datetime.changes (revision 0) +++ meegotouchcp-datetime.changes (revision 10) @@ -0,0 +1,143 @@ +* Tue Oct 04 2011 Marko Saukko <[email protected]> - 0.10.3 +- Updated to latest upstream version. + +* Fri Aug 12 2011 Gabor Juhasz <[email protected]> - 0.7.71 +- BMC#16755 - meegotouchcp-datetime-tests does not work with test automation + +* Mon Jul 08 2011 Gabor Juhasz <[email protected]> - 0.7.71 +- BMC#20847 - New version of datetime applet 0.7.71 +- Fixes: BMC#20581 - Calendar and date text doesn't fit screen size +- Fixes: BMC#20585 - Arrows-icon for am/pm in datetime applet is grayed out +- Fixed: BMC#20499 - Missing synch between 12/24 setting and time in datetime apple + +* Mon Jul 01 2011 Gabor Juhasz <[email protected]> - 0.7.69 +- BMC#20584 - New version of datetime applet 0.7.69 +- Fixes: BMC#20101 - qt calendar control isn't good in portrait mode +- Fixes: BMC#20265 - Unable to set time in datetime applet +- Fixes: Time Zones; Capital of Japan, Tokyo is replaced in Time zone. + +* Mon Jun 27 2011 Gabor Juhasz <[email protected]> - 0.7.67 +- BMC#20102 - New version of datetime +- Fixed BMC#17619 - New date screen for meego +- Fixes: There are some strings that are displayed doubled with both long and medium translation (with a square displayed in between) in Time Zone settings view. +- Fixes: Time setting not as designed +- Fixes: Update automatically german localization breaks layout. Thanks for the workaround to Hundhammer Stefan +- Fixes: User is allowed to set time in the past -- beyond of "invalid time" threshold +- Fixes: Common picker calendar date picker should be black +- Fixes: Text in the banner is displaying truncated for the given scenario. +- Fixes: Timezone list is not getting localized according to the language changes. +- Fixes: Logical String qtn_dtpi_select_month displayed when selecting month +- Fixes: List item labels not aligned properly and missing drill down icons +- Fixes: Deprecated enum MeeGo::QmTimeWhatChanged is used +- Fixes: Offset to GMT wrongly represented for the Western Hemisphere in time zone list +- Fixes: TimeZone starting with T are showing after M in time zone settings +- Fixes: Non geographical time zones are shown wrong +- Fixes: DateTimePanel is deprecated +- Fixes: AM/PM is not displaying properly and text is truncated. +- Fixes: Horizontal separator update needed +- Fixes: Name of the cities in Time zone setup are not in alphabetical order +- Fixes: Time zone list in suw view shows the search entry on reopening it in a given scenario. +- Fixes: Horizontal separator update needed +- Fixes: List item labels not aligned properly and missing drill down icons +- Fixes: Layout issues +- Fixes: Deprecated method MeeGo::QmTime::setTime(QDateTime const&) is used (by duicontrolpanel-datetimeapplet) + +* Mon Jun 13 2011 Gabor Juhasz <[email protected]> - 0.7.50.13.1 +- BMC#19315 +- Initial version of meegotouchcp-datetime in DE +- Gathering patches. + +* Thu Apr 28 2011 Gabor Juhasz <[email protected]> - 0.7.50.13 +- 3 patches for meegotouchcp-datetime : BMC#16835 +- BMC#15676 Top Bar Time format for clock doesn't work on boot +- BMC#16535 Year, month and day fields have no manual input option for Date settings +- BMC#16777 Removing automatic timeupdate UI control + +* Tue Apr 26 2011 Gabor Juhasz <[email protected]> - 0.7.50.10 +- Increasing version number to the last tag version number + +* Thu Apr 14 2011 Gabor Juhasz <[email protected]> - 0.7.50.1 +- 3 Patches for meegotouchcp-datetime : BMC#16079 +- BMC#14301 Don not require cellular net if not using cellular qt by Tapio +- BMC#15899 Datetime can't be compiled with new qmsystem +- BMC#15677 No difference between analog and digital clock +- Fixing desktop file path in yaml file + +* Mon Apr 04 2011 Gabor Juhasz <[email protected]> - 0.7.50.1 +- Patch for meegotouchcp-datetime +- BCM_10785_DateWeek_number_missing_in_calendar_view_in_TimeDate_setting_sometimes.patch + +* Fri Apr 01 2011 Gabor Juhasz <[email protected]> - 0.7.50.1 +- Patch for meegotouchcp-datetime - BMC#15136 +- BMC#14277 Time-view-does-not-follow-time-view-setting.patch + +* Tue Mar 08 2011 Gabor Juhasz <[email protected]> - 0.7.50.1 +- New version of datetime applet - BMC#14278 +- Merging meego stuff +- Fixes: Clock AM/PM is not updating in Time and Date +- Fixes: libdatetimeapplet uses deprecated styles +- Fixes: Digital clock is not visible in Time and date settings +- Fixes: Date Time; layout; automatic time updates toggle button layout is not align with the label +- Fixes: Wrong info banner is shown if network disabled and user tries to switch on ?Automatic Time Update? +- Fixes truncation problem in Date View +- Fixing datetimepanel mock due to the new api +- Fixing unit tests +- Fixes: Time is not centre-aligned as per Specifications. +- Fixes: The left display shows '...' for 40 and 04 and 00 minute +- Fixes: Date is truncated in settings application when the regional format is selected as UK +- Fixes: Settings; ?qqtn_date_time_title? header title is clipped in Indonesian portrait +- Fixes: Time value is not getting localized in the time setting view +- Creating a simple program to test qmsystem + +* Wed Jan 17 2011 Gabor Juhasz <[email protected]> - 0.7.43.6 +- BMC#12637 +- Adding a simple qmsystem test program +- Fixing date setting. +- New temporary time-picker to set time instead of VKB or HKB. +- Fixes: Settings: Time and date; inconsistent layout for Common Group Divider in landscape and portrait modes +- Fixes: After selecting USA, GMT-9.00 Adak, Alaska timezone System settings application always crashes +- Fixes: Automatic time update button looks like overlapping with view slider. +- Fixed: datetime applet crashes when gets run in separate process +- Fixes: datetime applet shows only one city per list item on timezone selection view +- Fixes: second level character is inserted from HKB while entering the first character in time zone filtering + +* Thu Jan 13 2011 Gabor Juhasz <[email protected]> - 0.7.43 +- The new formal release of datetime applet with qmsystem + +* Mon Jan 10 2011 Gabor Juhasz <[email protected]> - 0.7.43RC1 +- Trying new version of datetime applet with qmsystem + +* Fri Dec 10 2010 Rakesh Cherian <[email protected]> - 0.7.40 +- Giving permissions for /etc/sudoers + +* Fri Dec 10 2010 Gabor Juhasz <[email protected]> - 0.7.40 +- BMC #11189 +- Replacing libmeegocontrolpanel-devel with pkgconfig(meegotouch-controlpanel) +- Fixes: Timezone list items have wrong city names, offset, and some of them missing +- Adding search support +- Using inverted MList style +- Fixes: In System settings "Time and date" view the default Clock type setting should be Analog instead of Digital +- Restores auto scroll to selected timezone - removing open-time optimalization of Timezone View temporary until a perfect solution +- Startup time is <100 ms for all views except Date: MonthWidget is responsible for this, nothing to do from this side +- Default clock type is analog +- Fixes: Date & Time applet should have Clock type setting +- Fixes: Auto time: Shorter version of string ?qtn_date_try_later? is not clear in czech +- Fixes: Time format; selected time format`s highlighting has problem +- Fixes: Time and date layout is not as per layout guide. +- Fixes: BMC#9957,While change the Time from settings application crash and device reboots + +* Tue Nov 16 2010 Gabor Juhasz <[email protected]> - 0.7.34 +- New version of datetimeapplet : 0.7.34 +- Adding missing sudoers postinstall +- Adding new icu PackageConfig +- Adding missing AsWholeName option +- Adding missing engineer lang requires +- BMC#8328 + +* Thu Oct 14 2010 Gabor Juhasz <[email protected]> - 0.7.24 +- Removing RequiresPost from yaml file +- Replacing "Builder: make" with "Builder: qmake" + +* Tue Oct 12 2010 Gabor Juhasz <[email protected]> - 0.7.24 +- Initial version of meegotouchcp-datetime + Index: meegotouchcp-datetime.spec =================================================================== --- meegotouchcp-datetime.spec (revision 0) +++ meegotouchcp-datetime.spec (revision 10) @@ -0,0 +1,113 @@ +# +# Do NOT Edit the Auto-generated Part! +# Generated by: spectacle version 0.23 +# +# >> macros +# << macros + +Name: meegotouchcp-datetime +Summary: MeeGo Language Settings +Version: 0.10.3 +Release: 1 +Group: Application Framework/MeeGo Touch Settings +License: LGPLv2.1 +URL: http://meego.gitorious.org/meegotouch/meegotouch-controlpaneldatetimeapplet +Source0: %{name}-%{version}.tar.bz2 +Source100: meegotouchcp-datetime.yaml +Patch0: BMC_16755_Meegotouchcp-datetime-tests_does_not_work_with_test_automation.patch +Patch1: meegotouchcp-datetime-0.10.3-timepicker-define.patch +Requires: meegotouchcp-datetime-l10n-engineering-english = %{version} +BuildRequires: pkgconfig(QtGui) +BuildRequires: pkgconfig(icu-uc) +BuildRequires: pkgconfig(meegotouch) +BuildRequires: pkgconfig(meegotouch-controlpanel) +BuildRequires: pkgconfig(qmsystem2) + + +%description +MeegoTouchControlPanel plugin to set date and time. + + +%package -n meegotouchcp-datetime-l10n-engineering-english +Summary: Engineering English translations for the datetime applet +Group: System/Libraries +Requires: %{name} = %{version}-%{release} + +%description -n meegotouchcp-datetime-l10n-engineering-english +Engineering English translations for the datetime applet + + +%package -n meegotouchcp-datetime-tests +Summary: meegotouchcp-datetime applet functional and unit tests +Group: System/Libraries +Requires: %{name} = %{version}-%{release} +Requires: meegotouchcp-datetime = %{version} + +%description -n meegotouchcp-datetime-tests +Functional and Unit testing binaries and shellscripts for testing meegotouchcp-datetime applet + + + +%prep +%setup -q -n %{name}-%{version} + +# BMC_16755_Meegotouchcp-datetime-tests_does_not_work_with_test_automation.patch +%patch0 -p1 +# meegotouchcp-datetime-0.10.3-timepicker-define.patch +%patch1 -p1 +# >> setup +# << setup + +%build +# >> build pre +# << build pre + +%qmake + +make %{?jobs:-j%jobs} + +# >> build post +# << build post +%install +rm -rf %{buildroot} +# >> install pre +# << install pre +%qmake_install + +# >> install post +# << install post + + + + + + + + + + + + +%files +%defattr(-,root,root,-) +%{_libdir}/duicontrolpanel/* +%{_datadir}/duicontrolpanel-datetimeapplet/* +%{_datadir}/duicontrolpanel/desktops/datetime.desktop +%{_datadir}/themes/base/meegotouch/libdatetimeapplet/style/libdatetimeapplet.css +# >> files +# << files + + +%files -n meegotouchcp-datetime-l10n-engineering-english +%defattr(-,root,root,-) +%{_datadir}/l10n/meegotouch/date-time.qm +# >> files meegotouchcp-datetime-l10n-engineering-english +# << files meegotouchcp-datetime-l10n-engineering-english + +%files -n meegotouchcp-datetime-tests +%defattr(-,root,root,-) +%{_libdir}/meegotouchcp-datetime-tests/* +%{_datadir}/meegotouchcp-datetime-tests/* +# >> files meegotouchcp-datetime-tests +# << files meegotouchcp-datetime-tests + Index: meegotouchcp-datetime-0.10.3.tar.bz2 =================================================================== Binary file meegotouchcp-datetime-0.10.3.tar.bz2 added Index: meegotouchcp-datetime-0.10.3-timepicker-define.patch =================================================================== --- meegotouchcp-datetime-0.10.3-timepicker-define.patch (revision 0) +++ meegotouchcp-datetime-0.10.3-timepicker-define.patch (revision 10) @@ -0,0 +1,61 @@ +diff -ruN --exclude='*~' meegotouchcp-datetime-0.10.3.orig/dcpapplet/src/timeview.cpp meegotouchcp-datetime-0.10.3/dcpapplet/src/timeview.cpp +--- meegotouchcp-datetime-0.10.3.orig/dcpapplet/src/timeview.cpp 2011-10-04 16:59:03.193298884 +0300 ++++ meegotouchcp-datetime-0.10.3/dcpapplet/src/timeview.cpp 2011-10-04 17:05:39.534801740 +0300 +@@ -64,7 +64,9 @@ + + TimeView::~TimeView() + { ++#ifdef HAVE_TIMEPICKER + delete m_Locale; ++#endif + } + + void TimeView::acceptTime() +@@ -79,6 +81,7 @@ + dismiss(); + } + ++#ifdef HAVE_TIMEPICKER + void TimeView::createTimeLabelsLayout() + { + /* Create the labels */ +@@ -129,8 +132,8 @@ + m_hhSMmLayout->addItem(m_hourLabel, Qt::AlignVCenter); + m_hhSMmLayout->addItem(m_separatorLabel, Qt::AlignVCenter); + m_hhSMmLayout->addItem(m_minuteLabel, Qt::AlignVCenter); +- + } ++#endif + + void TimeView::initWidget() + { +diff -ruN --exclude='*~' meegotouchcp-datetime-0.10.3.orig/dcpapplet/src/timeview.h meegotouchcp-datetime-0.10.3/dcpapplet/src/timeview.h +--- meegotouchcp-datetime-0.10.3.orig/dcpapplet/src/timeview.h 2011-10-04 16:59:03.191298842 +0300 ++++ meegotouchcp-datetime-0.10.3/dcpapplet/src/timeview.h 2011-10-04 17:05:55.131136333 +0300 +@@ -49,7 +49,9 @@ + + private: + void addHeader(); ++#ifdef HAVE_TIMEPICKER + void createTimeLabelsLayout(); ++#endif + private slots: + void acceptTime(); + void timeOrDateChangedSlot(); +diff -ruN --exclude='*~' meegotouchcp-datetime-0.10.3.orig/dcpapplet/tests/doubles/timeview-fake.cpp meegotouchcp-datetime-0.10.3/dcpapplet/tests/doubles/timeview-fake.cpp +--- meegotouchcp-datetime-0.10.3.orig/dcpapplet/tests/doubles/timeview-fake.cpp 2011-10-04 16:59:03.198298992 +0300 ++++ meegotouchcp-datetime-0.10.3/dcpapplet/tests/doubles/timeview-fake.cpp 2011-10-04 17:20:09.726470274 +0300 +@@ -84,12 +84,12 @@ + { + } + ++#ifdef HAVE_TIMEPICKER + void TimeView::createTimeLabelsLayout() + { + + } + +-#ifdef HAVE_TIMEPICKER + void TimeView::pickerReleasedSlot() + { + Index: Makefile =================================================================== --- Makefile (revision 0) +++ Makefile (revision 10) @@ -0,0 +1,5 @@ +PKG_NAME := meegotouchcp-datetime +SPECFILE = $(addsuffix .spec, $(PKG_NAME)) +YAMLFILE = $(addsuffix .yaml, $(PKG_NAME)) + +include /usr/share/packaging-tools/Makefile.common Index: BMC_16755_Meegotouchcp-datetime-tests_does_not_work_with_test_automation.patch =================================================================== --- BMC_16755_Meegotouchcp-datetime-tests_does_not_work_with_test_automation.patch (revision 0) +++ BMC_16755_Meegotouchcp-datetime-tests_does_not_work_with_test_automation.patch (revision 10) @@ -0,0 +1,48 @@ +diff --git a/dcpapplet/tests/common_top.pri b/dcpapplet/tests/common_top.pri +index c2039a3..dd4aaef 100644 +--- a/dcpapplet/tests/common_top.pri ++++ b/dcpapplet/tests/common_top.pri +@@ -47,7 +47,7 @@ DEFINES += UNIT_TEST + DEFINES += DCP_DISABLE_DEPRECATION_WARNING + + +-DCP_TESTS_INSTALL_LIB = $${DCP_INSTALL_LIB}/duicontrolpanel-datetimeapplet-tests ++DCP_TESTS_INSTALL_LIB = $${DCP_INSTALL_LIB}/meegotouchcp-datetime-tests + target.path = $${DCP_TESTS_INSTALL_LIB} + INSTALLS += target + include(check.pri) +diff --git a/dcpapplet/tests/gen-tests-xml.sh b/dcpapplet/tests/gen-tests-xml.sh +index 8c14d7b..74da124 100755 +--- a/dcpapplet/tests/gen-tests-xml.sh ++++ b/dcpapplet/tests/gen-tests-xml.sh +@@ -7,7 +7,7 @@ for TEST in `ls -d ?t_*`; do + if [ -x $TEST/$TEST ]; then + + TESTCASE_TEMPLATE="<case name=\"$TEST\" description=\"$TEST\" requirement=\"\" timeout=\"60\"> +- <step expected_result=\"0\">/usr/lib/duicontrolpanel-datetimeapplet-tests/$TEST</step> ++ <step expected_result=\"0\">/usr/lib/meegotouchcp-datetime-tests/$TEST</step> + </case> + " + +@@ -21,7 +21,7 @@ done + + TESTSUITE_TEMPLATE="<?xml version=\"1.0\" encoding=\"ISO-8859-1\"?> + <testdefinition version=\"0.1\"> +- <suite name=\"duicontrolpanel-datetimeapplet-tests\"> ++ <suite name=\"meegotouchcp-datetime-tests\"> + <set name=\"unit_tests\" description=\"Unit Tests\"> + + $UT_TESTCASES +diff --git a/dcpapplet/tests/shell.pri b/dcpapplet/tests/shell.pri +index 2caa77f..8348fd2 100644 +--- a/dcpapplet/tests/shell.pri ++++ b/dcpapplet/tests/shell.pri +@@ -2,7 +2,7 @@ include(../common.pri) + shell_scripts.commands += ./gen-tests-xml.sh > tests.xml + shell_scripts.files += tests.xml + +-shell_scripts.path += $$(DCP_PREFIX)/usr/share/duicontrolpanel-datetimeapplet-tests ++shell_scripts.path += $$(DCP_PREFIX)/usr/share/meegotouchcp-datetime-tests + + shell_scripts.CONFIG += no_check_exist +
