I have made the following changes intended for : CE:Apps / qmlreddit Please review and accept or decline. BOSS has already run some checks on this request. See the "Messages from BOSS" section below.
https://build.pub.meego.com//request/show/3404 Thank You, bossbot ([email protected]) [This message was auto-generated] --- Request # 3404: Messages from BOSS: Could not notify CE-maintainers (no address found) State: review 2011-12-07T11:49:42 bossbot Reviews: accepted by bossbot : Prechecks completed; none failed. new by : Please replace this text with a review and approve/reject the review (not the SR). BOSS will take care of the rest Changes: submit: home:jakub:branches:CE:Apps / qmlreddit -> CE:Apps / qmlreddit changes files: -------------- --- info.vivainio.qmlreddit.changes +++ info.vivainio.qmlreddit.changes @@ -0,0 +1,3 @@ +* Wed Dec 07 2011 Jakub Pavelek <[email protected]> - 1.0 +- On packaging level, install fixed desktop and app icon under new name + new: ---- info.vivainio.qmlreddit.desktop spec files: ----------- --- info.vivainio.qmlreddit.spec +++ info.vivainio.qmlreddit.spec @@ -1,6 +1,6 @@ # # Do NOT Edit the Auto-generated Part! -# Generated by: spectacle version 0.22 +# Generated by: spectacle version 0.23 # # >> macros # << macros @@ -8,11 +8,12 @@ Name: info.vivainio.qmlreddit Summary: Reddit reader application Version: 1.0 -Release: 1 +Release: 2 Group: Applications/Internet License: GPL URL: http://sites.google.com/site/qmlreddit/ Source0: %{name}-%{version}.tar.gz +Source1: info.vivainio.qmlreddit.desktop Source100: info.vivainio.qmlreddit.yaml Requires: libqtwebkit-qmlwebkitplugin BuildRequires: pkgconfig(QtCore) >= 4.7.0 @@ -50,6 +51,10 @@ %qmake_install # >> install post +mkdir -p %{buildroot}%{_datadir}/themes/base/meegotouch/icons/ +install -m 644 %{buildroot}%{_datadir}/icons/hicolor/64x64/apps/info.vivainio.qmlreddit.png %{buildroot}%{_datadir}/themes/base/meegotouch/icons/qmlreddit.png +mkdir -p %{buildroot}%{_datadir}/applications +install -m 644 %{SOURCE1} %{buildroot}%{_datadir}/applications/ # << install post desktop-file-install --delete-original \ --dir %{buildroot}%{_datadir}/applications \ @@ -65,6 +70,7 @@ %{_datadir}/applications/%{name}.desktop /opt/%{name} %{_datadir}/icons/hicolor/*/apps/%{name}.png +%{_datadir}/themes/base/meegotouch/icons/qmlreddit.png # >> files # << files other changes: -------------- ++++++ info.vivainio.qmlreddit.desktop (new) --- info.vivainio.qmlreddit.desktop +++ info.vivainio.qmlreddit.desktop @@ -0,0 +1,15 @@ + +[Desktop Entry] +Encoding=UTF-8 +Version=1.0 +Type=Application +Terminal=false +Name=QmlReddit +Comment=Reddit Reader +Exec=/opt/info.vivainio.qmlreddit/bin/qmlreddit +Icon=qmlreddit +X-Window-Icon= +X-HildonDesk-ShowInToolbar=true +X-Osso-Type=application/x-executable +Categories=Network; +X-Desktop-File-Install-Version=0.18 ++++++ info.vivainio.qmlreddit.yaml --- info.vivainio.qmlreddit.yaml +++ info.vivainio.qmlreddit.yaml @@ -1,12 +1,13 @@ Name: info.vivainio.qmlreddit Summary: Reddit reader application Version: 1.0 -Release: 1 +Release: 2 Group: Applications/Internet License: GPL URL: http://sites.google.com/site/qmlreddit/ Sources: - "%{name}-%{version}.tar.gz" + - "info.vivainio.qmlreddit.desktop" Description: Browse Reddit (popular link sharing/discussion website) in technicolor. Supports login, fetching of subscriptions, voting on links and @@ -25,3 +26,4 @@ - "%{_datadir}/applications/%{name}.desktop" - "/opt/%{name}" - "%{_datadir}/icons/hicolor/*/apps/%{name}.png" + - "%{_datadir}/themes/base/meegotouch/icons/qmlreddit.png"
