I have made the following changes intended for :
  CE:Apps / PackMan
  CE:Apps / qatbowling
  CE:Apps / qtflyingbus

Please review and accept or decline.
BOSS has already run some checks on this request.
See the "Messages from BOSS" section below.

https://build.pub.meego.com//request/show/4295

Thank You,
Marko Saukko

[This message was auto-generated]

---

Request # 4295:

Messages from BOSS:

State: review at 2012-02-01T12:46:58 by bossbot

Reviews:
       accepted by bossbot : Prechecks succeeded.
       new for CE-maintainers : Please replace this text with a review and 
approve/reject the review (not the SR). BOSS will take care of the rest

Changes:
  submit: home:sage:branches:CE:Apps / PackMan -> CE:Apps / PackMan
  
changes files:
--------------
--- mg-package-manager.changes
+++ mg-package-manager.changes
@@ -0,0 +1,4 @@
+* Wed Feb 01 2012 Marko Saukko <[email protected]> - 0.2.1
+- Added mg-package-manager_screenshot.png
+- Minor packaging cleanups.
+

new:
----
  mg-package-manager_screenshot.png

spec files:
-----------
--- mg-package-manager.spec
+++ mg-package-manager.spec
@@ -8,18 +8,15 @@
 Group:     System
 License:   LGPLv2.1
 URL:       http://www.meego.com
-Source:    %{name}-%{version}.tar.gz
-Patch0:     mg-package-manager-0.2.1-link-with-missing-libs.patch
+Source0:    %{name}-%{version}.tar.gz
+Source1:    %{name}_screenshot.png
+Patch0:     %{name}-0.2.1-link-with-missing-libs.patch
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root
 
 BuildRequires: qt-devel
 BuildRequires:  PackageKit-devel >= %{packagekit_version}  
 BuildRequires:  PackageKit-qt-devel >= %{packagekit_version}  
 
-%if 0%{?fedora}
-BuildRequires: gcc-c++
-%endif
-
 Requires:   PackageKit >= %{packagekit_version}  
 Requires:   PackageKit-libs >= %{packagekit_version}  
 Requires:   PackageKit-qt >= %{packagekit_version}  
@@ -36,29 +33,16 @@
 %patch0 -p1
 
 %build
-%if 0%{?fedora}
-qmake-qt4
-%else
-qmake PREFIX=/usr
-%endif
+qmake PREFIX=%{_prefix}
 make %{?_smp_mflags}
 
-
 %install
 %{__rm} -rf $RPM_BUILD_ROOT
 %{__make} INSTALL_ROOT=%{buildroot} install
 
-%clean
-%{__rm} -rf $RPM_BUILD_ROOT
-
 %files
 %defattr(-,root,root)
 %{_bindir}/mg-package-manager
 %{_datadir}/applications/mg-package-manager.desktop
 %{_datadir}/pixmaps/mg-package-manager.png
 %{_datadir}/mg-package-manager/qml/*
-
-%post  
-   
-%postun  
-

other changes:
--------------

++++++ mg-package-manager_screenshot.png (new)
Binary files mg-package-manager_screenshot.png added

  submit: home:sage:branches:CE:Apps / qatbowling -> CE:Apps / qatbowling
  
changes files:
--------------
--- info.vivainio.qatbowling.changes
+++ info.vivainio.qatbowling.changes
@@ -0,0 +1,3 @@
+* Wed Feb 01 2012 Marko Saukko <[email protected]> - 1.0
+- Added screenshot.
+

new:
----
  info.vivainio.qatbowling_screenshot.png

spec files:
-----------
--- info.vivainio.qatbowling.spec
+++ info.vivainio.qatbowling.spec
@@ -13,6 +13,7 @@
 License:    GPL
 URL:        http://projects.forum.nokia.com/catbowling
 Source0:    %{name}-%{version}.tar.gz
+Source1:    info.vivainio.qatbowling_screenshot.png
 Source100:  info.vivainio.qatbowling.yaml
 Patch0:     xruxa_Nemo_specific_desktop.patch
 BuildRequires:  pkgconfig(QtCore) >= 4.7.0

other changes:
--------------

++++++ info.vivainio.qatbowling.yaml
--- info.vivainio.qatbowling.yaml
+++ info.vivainio.qatbowling.yaml
@@ -7,6 +7,7 @@
 URL: http://projects.forum.nokia.com/catbowling
 Sources:
     - "%{name}-%{version}.tar.gz"
+    - info.vivainio.qatbowling_screenshot.png
 Patches: 
     - xruxa_Nemo_specific_desktop.patch
 Description:  

++++++ info.vivainio.qatbowling_screenshot.png (new)
Binary files info.vivainio.qatbowling_screenshot.png added

  submit: home:sage:branches:CE:Apps / qtflyingbus -> CE:Apps / qtflyingbus
  
changes files:
--------------
--- qtflyingbus.changes
+++ qtflyingbus.changes
@@ -0,0 +1,3 @@
+* Wed Feb 01 2012 Marko Saukko <[email protected]> - 0.1
+- Added screenshot.
+

new:
----
  qtflyingbus_screenshot.png

spec files:
-----------
--- qtflyingbus.spec
+++ qtflyingbus.spec
@@ -5,10 +5,10 @@
 License: BSD
 Url:    https://qt.gitorious.org/qt-labs/mobile-demos
 Group: Applications/Games
-Source: %{name}-%{version}.tar.gz
+Source0: %{name}-%{version}.tar.gz
 Source1: icon-qtflyingbus-32x32.png
+Source2: qtflyingbus_screenshot.png
 Patch0: installation.patch
-BuildRoot: %{_tmppath}/%{name}-%{version}-root
 
 BuildRequires: qt-devel
 
@@ -31,9 +31,6 @@
 make INSTALL_ROOT=%{buildroot} install
 install -m 644 -D %{SOURCE1} 
%{buildroot}/usr/share/pixmaps/icon-qtflyingbus.png
 
-%clean
-%{__rm} -rf %{buildroot}
-
 %files
 %defattr(-,root,root,-)
 %{_bindir}/*

other changes:
--------------

++++++ qtflyingbus_screenshot.png (new)
Binary files qtflyingbus_screenshot.png added



Reply via email to