I have made the following changes intended for :
  CE:Apps / qmlfilemuncher

Please review and accept or decline.
BOSS has already run some checks on this request.
See the "Messages from BOSS" section below.

https://build.pub.meego.com//request/show/4381

Thank You,
vesku

[This message was auto-generated]

---

Request # 4381:

Messages from BOSS:

State: review at 2012-02-16T16:02:14 by bossbot

Reviews:
       accepted by bossbot : Prechecks succeeded.
       new for CE-maintainers : Please replace this text with a review and 
approve/reject the review (not the SR). BOSS will take care of the rest

Changes:
  submit: home:vesku:branches:CE:Apps / qmlfilemuncher -> CE:Apps / 
qmlfilemuncher
  
changes files:
--------------
--- qmlfilemuncher.changes
+++ qmlfilemuncher.changes
@@ -0,0 +1,4 @@
+* Thu Feb 16 2012 Vesa-Matti Hartikainen <[email protected]> - 
0.0.3
+- Release for Nemo 0.0.3
+-- Visual improvements
+

old:
----
  qmlfilemuncher-0.0.2.tar.bz2

new:
----
  qmlfilemuncher-0.0.3.tar.bz2

spec files:
-----------
--- qmlfilemuncher.spec
+++ qmlfilemuncher.spec
@@ -7,7 +7,7 @@
 
 Name:       qmlfilemuncher
 Summary:    File Manager for Nemo
-Version:    0.0.2
+Version:    0.0.3
 Release:    1
 Group:      System/Libraries
 License:    BSD

other changes:
--------------

++++++ qmlfilemuncher-0.0.2.tar.bz2 -> qmlfilemuncher-0.0.3.tar.bz2
--- Directory.qml
+++ Directory.qml
@@ -30,7 +30,7 @@
  */
 
 import QtQuick 1.1
-import com.nokia.meego 1.1
+import com.nokia.meego 1.0
 import FBrowser 1.0
 
 Page {
@@ -41,6 +41,7 @@
     Rectangle {
         id: header
         height: window.inPortrait ? 72 : 0
+        visible: window.inPortrait ? true : false
         color: "#EA650A"
         anchors.top: parent.top
         anchors.left: parent.left
@@ -70,7 +71,12 @@
         }
     }
 
+    ScrollDecorator {
+        flickableItem: fileList
+    }
+
     ListView {
+        id: fileList
         anchors.top: header.bottom
         anchors.bottom: page.bottom
         anchors.left: page.left
@@ -88,12 +94,23 @@
                     if (model.isDir)
                         window.cdInto(model.filePath)
                     else
-                        dirModel.openFile(model.filePath)
+                        Qt.openUrlExternally("file://" + model.filePath)
                 }
             }
         }
     }
 
+    Label {
+        // TODO: this should be made bigger. can we get the correct size 
somehow?
+        id: noFilesText
+        text: "No items here."
+        color: "#8c8c8c" // TODO: won't work with an inverted theme
+        smooth: true
+        anchors {verticalCenter: parent.verticalCenter; topMargin: 40; 
horizontalCenter: parent.horizontalCenter;}
+        visible: fileList.count == 0 ? true : false;
+
+    }
+
     tools: ToolBarLayout {
         ToolIcon {
             iconId: "icon-m-toolbar-back"
--- FileItemDelegate.qml
+++ FileItemDelegate.qml
@@ -30,7 +30,7 @@
  */
 
 import QtQuick 1.1
-import com.nokia.meego 1.1
+import com.nokia.meego 1.0
 
 Rectangle {
     property bool navigationMode: true
@@ -68,6 +68,8 @@
         source: "image://theme/icon-m-common-drilldown-arrow" + 
(theme.inverted ? "-inverse" : "")
         anchors.right: parent.right;
         anchors.verticalCenter: parent.verticalCenter
+        asynchronous: true
+        cache: true
     }
 }
 
--- FilePickerSheet.qml
+++ FilePickerSheet.qml
@@ -30,7 +30,7 @@
  */
 
 import QtQuick 1.1
-import com.nokia.meego 1.1
+import com.nokia.meego 1.0
 
 Sheet {
     id: sheet
--- main.cpp
+++ main.cpp
@@ -229,11 +229,6 @@
         refresh();
     }
 
-    Q_INVOKABLE void openFile(const QString &path)
-    {
-        QDesktopServices::openUrl(QUrl::fromLocalFile(path));
-    }
-
 signals:
     void pathChanged();
 
--- main.qml
+++ main.qml
@@ -30,7 +30,7 @@
  */
 
 import QtQuick 1.1
-import com.nokia.meego 1.1
+import com.nokia.meego 1.0
 
 PageStackWindow {
     id: window

++++++ qmlfilemuncher.yaml
--- qmlfilemuncher.yaml
+++ qmlfilemuncher.yaml
@@ -1,6 +1,6 @@
 Name:  qmlfilemuncher
 Summary: File Manager for Nemo
-Version: 0.0.2
+Version: 0.0.3
 Release: 1
 Group:   System/Libraries
 License:    BSD



Reply via email to