I have made the following changes intended for : CE:MW:MTF / libcubi-tracker-ontologies CE:MW:MTF / libcubi CE:MW:MTF / qtcontacts-tracker CE:MW:MTF / libcommhistory CE:MW:MTF / commhistory-daemon
Please review and accept or decline. BOSS has already run some checks on this request. See the "Messages from BOSS" section below. https://build.pub.meego.com//request/show/5406 Thank You, tswindell [This message was auto-generated] --- Request # 5406: Messages from BOSS: State: review at 2012-08-03T10:58:16 by bossbot Reviews: accepted by bossbot : Prechecks succeeded. new for CE-maintainers : Please replace this text with a review and approve/reject the review (not the SR). BOSS will take care of the rest Changes: submit: home:tswindell:CE:Apps / libcubi-tracker-ontologies -> CE:MW:MTF / libcubi-tracker-ontologies changes files: -------------- ++++++ new changes file: --- libcubi-tracker-ontologies-devel.changes +++ libcubi-tracker-ontologies-devel.changes @@ -0,0 +1,7 @@ +* Mon Jul 30 2012 Tom Swindell <[email protected]> - 0.1.4+git4.dfb3d63 +- Updated sources from upstream git, for libcommhistory and commhistory-daemon packaging. +- Renamed package to -devel to supress rpmbuild warnings. + +* Tue Sep 20 2011 Robin Burchell <[email protected]> - 0.1.1 +- introduce libcubi-tracker-ontologies; a compiled form of the tracker + ontologies, needed for the qtcontacts-tracker update ++++++ deleted changes files: --- libcubi.changes old: ---- cubi-ontologies-tracker-0.1.1-1.tar.gz libcubi-tracker-ontologies.spec libcubi-tracker-ontologies.yaml libcubi.changes new: ---- cubi-ontologies-tracker-0.1.4+git4.dfb3d63.tar.gz libcubi-tracker-ontologies-devel.changes libcubi-tracker-ontologies-devel.spec libcubi-tracker-ontologies-devel.yaml spec files: ----------- ++++++ new spec file: --- libcubi-tracker-ontologies-devel.spec +++ libcubi-tracker-ontologies-devel.spec @@ -0,0 +1,62 @@ +# +# Do NOT Edit the Auto-generated Part! +# Generated by: spectacle version 0.24 +# + +Name: libcubi-tracker-ontologies-devel + +# >> macros +# << macros +%define keepstatic 1 + +Summary: Tracker ontologies generated using libcubi's ontology generator +Version: 0.1.4+git4.dfb3d63 +Release: 1 +Group: System/Libraries +License: LGPL +URL: http://gitorious.org/cubi +Source0: cubi-ontologies-tracker-%{version}.tar.gz +Source100: libcubi-tracker-ontologies-devel.yaml +BuildRequires: pkgconfig(QtCore) +BuildRequires: libcubi-devel + +%description +Ontologies for Tracker generated using libcubi's ontology generator + + + +%prep +%setup -q -n cubi-ontologies-tracker-%{version} + +# >> setup +# << setup + +%build +# >> build pre +./configure --prefix=/usr +# << build pre + + +make %{?jobs:-j%jobs} + +# >> build post +# << build post + +%install +rm -rf %{buildroot} +# >> install pre +# << install pre +%make_install + +# >> install post +# << install post + + +%files +%defattr(-,root,root,-) +%{_includedir}/* +%{_libdir}/*.a +%{_libdir}/pkgconfig/* +%{_datadir}/qt4/mkspecs/features/* +# >> files +# << files ++++++ deleted spec files: --- libcubi-tracker-ontologies.spec other changes: -------------- ++++++ cubi-ontologies-tracker-0.1.4+git4.dfb3d63.tar.gz (new) ++++++ libcubi-tracker-ontologies-devel.yaml (new) --- libcubi-tracker-ontologies-devel.yaml +++ libcubi-tracker-ontologies-devel.yaml @@ -0,0 +1,24 @@ +Name: libcubi-tracker-ontologies-devel +Summary: Tracker ontologies generated using libcubi's ontology generator +Version: 0.1.4+git4.dfb3d63 +Release: 1 +Group: System/Libraries +License: LGPL +URL: http://gitorious.org/cubi +Sources: + - "cubi-ontologies-tracker-%{version}.tar.gz" +Description: | + Ontologies for Tracker generated using libcubi's ontology generator + +PkgBR: + - libcubi-devel +PkgConfigBR: + - QtCore +Configure: none +Builder: make +Files: + - "%{_includedir}/*" + - "%{_libdir}/*.a" + - "%{_libdir}/pkgconfig/*" + - "%{_datadir}/qt4/mkspecs/features/*" + ++++++ deleted files: --- cubi-ontologies-tracker-0.1.1-1.tar.gz --- libcubi-tracker-ontologies.yaml submit: home:tswindell:CE:Apps / libcubi -> CE:MW:MTF / libcubi changes files: -------------- --- libcubi.changes +++ libcubi.changes @@ -0,0 +1,3 @@ +* Mon Jul 30 2012 Tom Swindell <[email protected]> - 0.1.17+git2.911d174 +- Updated source version. + old: ---- Makefile cubi-0.1.14-1.tar.gz new: ---- cubi-0.1.17+git2.911d174.tar.gz spec files: ----------- --- libcubi.spec +++ libcubi.spec @@ -1,13 +1,12 @@ Name: libcubi -Version: 0.1.14 -%define tagnr -1 +Version: 0.1.17+git2.911d174 Release: 1%{?dist} Summary: Simple SPARQL query builder library for Qt applications Group: System/Libraries License: LGPL URL: http://gitorious.org/cubi -Source0: cubi-%{version}%{tagnr}.tar.gz +Source0: cubi-%{version}.tar.gz BuildRequires: pkgconfig(QtCore) BuildRequires: pkgconfig(QtSparql) @@ -25,7 +24,7 @@ Development files for Cubi %prep -%setup -q -n cubi-%{version}%{tagnr} +%setup -q -n cubi-%{version} %build %reconfigure other changes: -------------- ++++++ cubi-0.1.17+git2.911d174.tar.gz (new) ++++++ deleted files: --- Makefile --- cubi-0.1.14-1.tar.gz submit: home:tswindell:CE:Apps / qtcontacts-tracker -> CE:MW:MTF / qtcontacts-tracker changes files: -------------- --- qtcontacts-tracker.changes +++ qtcontacts-tracker.changes @@ -0,0 +1,3 @@ +* Tue Jul 31 2012 Tom Swindell <[email protected]> - 4.19.2 +- Updated sources from git, for libcommhistory and commhistory-daemon packages. + old: ---- 0001-fix-broken-docs-check-we-don-t-want-them.patch qtcontacts-tracker-4.16.1-1.tar.gz new: ---- qtcontacts-tracker-4.19.2-fix-broken-docs-check-we-don-t-want-them.patch qtcontacts-tracker-4.19.2-fix-field-extended-address-reference.patch qtcontacts-tracker-4.19.2-fix-private-dtor-in-thread-local-storage-class.patch qtcontacts-tracker-4.19.2.tar.gz spec files: ----------- --- qtcontacts-tracker.spec +++ qtcontacts-tracker.spec @@ -1,21 +1,25 @@ # # Do NOT Edit the Auto-generated Part! -# Generated by: spectacle version 0.23 +# Generated by: spectacle version 0.24 # + +Name: qtcontacts-tracker + # >> macros # << macros -Name: qtcontacts-tracker Summary: QtContact tracker storage plugin -Version: 4.16.1 +Version: 4.19.2 Release: 1 Group: System/Libraries License: LGPL v2.1 URL: http://gitorious.org/qtcontacts-tracker -Source0: qtcontacts-tracker-4.16.1-1.tar.gz +Source0: qtcontacts-tracker-%{version}.tar.gz Source100: qtcontacts-tracker.yaml -Patch0: 0001-fix-broken-docs-check-we-don-t-want-them.patch -Patch1: qtcontacts-tracker-4.16.1-fix-linking.patch +Patch0: qtcontacts-tracker-4.16.1-fix-linking.patch +Patch1: qtcontacts-tracker-4.19.2-fix-private-dtor-in-thread-local-storage-class.patch +Patch2: qtcontacts-tracker-4.19.2-fix-broken-docs-check-we-don-t-want-them.patch +Patch3: qtcontacts-tracker-4.19.2-fix-field-extended-address-reference.patch Requires: libqtsparql-tracker >= 0.0.18 BuildRequires: pkgconfig(QtContacts) >= 1.2 BuildRequires: pkgconfig(QtSparql) >= 0.0.18 @@ -24,15 +28,14 @@ BuildRequires: pkgconfig(QtDBus) BuildRequires: pkgconfig(QtGui) BuildRequires: libcubi-devel >= 0.1.14 -BuildRequires: libcubi-tracker-ontologies BuildRequires: tracker-devel >= 0.10.6 +BuildRequires: libcubi-tracker-ontologies-devel >= 0.1.4 BuildRequires: fdupes - +BuildRequires: python %description QtContact tracker storage plugin. - %package -n libqtcontacts-tracker-extensions Summary: Specific QContact extensions from qtcontacts-tracker Group: Development/Libraries @@ -75,12 +78,16 @@ %prep -%setup -q -n %{name}-%{version}-1 +%setup -q -n %{name}-%{version} -# 0001-fix-broken-docs-check-we-don-t-want-them.patch -%patch0 -p1 # qtcontacts-tracker-4.16.1-fix-linking.patch +%patch0 -p1 +# qtcontacts-tracker-4.19.2-fix-private-dtor-in-thread-local-storage-class.patch %patch1 -p1 +# qtcontacts-tracker-4.19.2-fix-broken-docs-check-we-don-t-want-them.patch +%patch2 -p1 +# qtcontacts-tracker-4.19.2-fix-field-extended-address-reference.patch +%patch3 -p1 # >> setup # << setup @@ -96,6 +103,7 @@ # >> build post # << build post + %install rm -rf %{buildroot} # >> install pre @@ -109,24 +117,10 @@ # << install post - - - - - %post -n libqtcontacts-tracker-extensions -p /sbin/ldconfig %postun -n libqtcontacts-tracker-extensions -p /sbin/ldconfig - - - - - - - - - %files %defattr(-,root,root,-) # >> files @@ -134,7 +128,6 @@ %exclude %{_datadir}/backup-framework/applications/libqtcontacts-tracker.conf # << files - %files -n libqtcontacts-tracker-extensions %defattr(-,root,root,-) # >> files libqtcontacts-tracker-extensions @@ -162,4 +155,3 @@ # >> files benchmarks %{_bindir}/bm_* # << files benchmarks - other changes: -------------- ++++++ qtcontacts-tracker-4.19.2-fix-broken-docs-check-we-don-t-want-them.patch (new) --- qtcontacts-tracker-4.19.2-fix-broken-docs-check-we-don-t-want-them.patch +++ qtcontacts-tracker-4.19.2-fix-broken-docs-check-we-don-t-want-them.patch @@ -0,0 +1,13 @@ +diff -uNr qtcontacts-tracker-4.19.2~498056e/libqtcontacts-tracker.pro qtcontacts-tracker.p2/libqtcontacts-tracker.pro +--- qtcontacts-tracker-4.19.2~498056e/libqtcontacts-tracker.pro 2012-07-31 07:34:35.873090690 +0000 ++++ qtcontacts-tracker.p2/libqtcontacts-tracker.pro 2012-07-31 07:46:47.977071044 +0000 +@@ -3,7 +3,8 @@ + + SUBDIRS = src tests benchmarks tools + +-equals(ENABLE_DOCS,yes) { ++ ++contains(CONFIG,ENABLE_DOCS) { + SUBDIRS += doc + } + ++++++ qtcontacts-tracker-4.19.2-fix-field-extended-address-reference.patch (new) --- qtcontacts-tracker-4.19.2-fix-field-extended-address-reference.patch +++ qtcontacts-tracker-4.19.2-fix-field-extended-address-reference.patch @@ -0,0 +1,48 @@ +diff -uNr qtcontacts-tracker/src/dao/contactdetailschema.cpp qtcontacts-tracker.p1/src/dao/contactdetailschema.cpp +--- qtcontacts-tracker/src/dao/contactdetailschema.cpp 2012-08-03 08:23:59.678055344 +0000 ++++ qtcontacts-tracker.p1/src/dao/contactdetailschema.cpp 2012-08-03 08:43:44.386023548 +0000 +@@ -132,10 +132,10 @@ + << QctPropertyInfo<nco::hasPostalAddress>().setHasDetailUri() + << QctPropertyInfo<nco::country>())); + +- addField(QctContactDetailField(QContactAddress::FieldExtendedAddress). ++ /*addField(QctContactDetailField(QContactAddress::FieldExtendedAddress). + setPropertyChain(QctPropertyInfoList() + << QctPropertyInfo<nco::hasPostalAddress>() +- << QctPropertyInfo<nco::extendedAddress>())); ++ << QctPropertyInfo<nco::extendedAddress>()));*/ + + addField(QctContactDetailField(QContactAddress::FieldLocality). + setPropertyChain(QctPropertyInfoList() +diff -uNr qtcontacts-tracker/tests/ut_qtcontacts_trackerplugin/ut_qtcontacts_trackerplugin.cpp qtcontacts-tracker.p1/tests/ut_qtcontacts_trackerplugin/ut_qtcontacts_trackerplugin.cpp +--- qtcontacts-tracker/tests/ut_qtcontacts_trackerplugin/ut_qtcontacts_trackerplugin.cpp 2012-08-03 08:23:59.690055344 +0000 ++++ qtcontacts-tracker.p1/tests/ut_qtcontacts_trackerplugin/ut_qtcontacts_trackerplugin.cpp 2012-08-03 08:48:40.810015597 +0000 +@@ -1293,7 +1293,7 @@ + values.insert(QLatin1String(QContactAddress::FieldCountry), "Barbados"); + values.insert(QLatin1String(QContactAddress::FieldPostcode), "55555"); + values.insert(QLatin1String(QContactAddress::FieldStreet), "Martindales Rd"); +- values.insert(QLatin1String(QContactAddress::FieldExtendedAddress), "In the Front Garden"); ++ //values.insert(QLatin1String(QContactAddress::FieldExtendedAddress), "In the Front Garden"); + values.insert(QLatin1String(QContactAddress::FieldRegion), "Bridgetown"); + values.insert(QLatin1String(QContactAddress::FieldLocality), "Bridgetown town"); + +@@ -1364,8 +1364,8 @@ + QContact contact = contacts.first(); + QCOMPARE(contact.details<QContactAddress>().count(), 1); + +- const QString extendedAddress = contact.detail<QContactAddress>().extendedAddress(); +- QCOMPARE(extendedAddress, QString::fromLatin1("Lawspet")); ++ /*const QString extendedAddress = contact.detail<QContactAddress>().extendedAddress(); ++ QCOMPARE(extendedAddress, QString::fromLatin1("Lawspet"));*/ + + // Check saving and fetching + QContactManager::Error error = QContactManager::UnspecifiedError; +@@ -1381,7 +1381,7 @@ + + QCOMPARE(fetchedContact.localId(), contact.localId()); + QCOMPARE(fetchedContact.details<QContactAddress>().count(), 1); +- QCOMPARE(fetchedContact.detail<QContactAddress>().extendedAddress(), extendedAddress); ++ //QCOMPARE(fetchedContact.detail<QContactAddress>().extendedAddress(), extendedAddress); + } + + void ++++++ qtcontacts-tracker-4.19.2-fix-private-dtor-in-thread-local-storage-class.patch (new) --- qtcontacts-tracker-4.19.2-fix-private-dtor-in-thread-local-storage-class.patch +++ qtcontacts-tracker-4.19.2-fix-private-dtor-in-thread-local-storage-class.patch @@ -0,0 +1,16 @@ +diff -uNr qtcontacts-tracker-4.19.2~498056e/src/lib/threadlocaldata.h qtcontacts-tracker.p/src/lib/threadlocaldata.h +--- qtcontacts-tracker-4.19.2~498056e/src/lib/threadlocaldata.h 2012-07-31 07:34:35.881090691 +0000 ++++ qtcontacts-tracker.p/src/lib/threadlocaldata.h 2012-07-31 07:40:17.273081527 +0000 +@@ -45,9 +45,11 @@ + + private: + QctThreadLocalData(); ++ ++public: + ~QctThreadLocalData(); + +-public: // singleton style accessor ++ // singleton style accessor + static QctThreadLocalData * instance(); + + public: // attributes ++++++ qtcontacts-tracker-4.16.1-1.tar.gz -> qtcontacts-tracker-4.19.2.tar.gz (44408 lines skipped) ++++++ qtcontacts-tracker.yaml --- qtcontacts-tracker.yaml +++ qtcontacts-tracker.yaml @@ -1,24 +1,27 @@ Name: qtcontacts-tracker Summary: QtContact tracker storage plugin -Version: 4.16.1 +Version: 4.19.2 Release: 1 Group: System/Libraries License: LGPL v2.1 URL: http://gitorious.org/qtcontacts-tracker Sources: - - "qtcontacts-tracker-4.16.1-1.tar.gz" + - "qtcontacts-tracker-%{version}.tar.gz" Patches: - - 0001-fix-broken-docs-check-we-don-t-want-them.patch - qtcontacts-tracker-4.16.1-fix-linking.patch + - qtcontacts-tracker-4.19.2-fix-private-dtor-in-thread-local-storage-class.patch + - qtcontacts-tracker-4.19.2-fix-broken-docs-check-we-don-t-want-them.patch + - qtcontacts-tracker-4.19.2-fix-field-extended-address-reference.patch Description: QtContact tracker storage plugin. Requires: - libqtsparql-tracker >= 0.0.18 PkgBR: - libcubi-devel >= 0.1.14 - - libcubi-tracker-ontologies - tracker-devel >= 0.10.6 + - libcubi-tracker-ontologies-devel >= 0.1.4 - fdupes + - python PkgConfigBR: - QtContacts >= 1.2 - QtSparql >= 0.0.18 ++++++ deleted files: --- 0001-fix-broken-docs-check-we-don-t-want-them.patch submit: home:tswindell:CE:Apps / libcommhistory -> CE:MW:MTF / libcommhistory changes files: -------------- ++++++ new changes file: --- libcommhistory.changes +++ libcommhistory.changes @@ -0,0 +1,3 @@ +* Tue Jul 31 2012 Tom Swindell <[email protected]> - 1.3.12.6 +- Initial project packaging. + new: ---- libcommhistory-1.3.12.6-fix-shared-static-lib-build-order.patch libcommhistory-1.3.12.6.tar.gz libcommhistory.changes libcommhistory.spec spec files: ----------- ++++++ new spec file: --- libcommhistory.spec +++ libcommhistory.spec @@ -0,0 +1,93 @@ +Name: libcommhistory +Summary: Communications event history database API +Version: 1.3.12.6 +Release: 1 +Group: System/Libraries +License: LGPL +URL: http://gitorious.org/commhistory/libcommhistory +Source0: %{name}-%{version}.tar.gz +Patch0: libcommhistory-1.3.12.6-fix-shared-static-lib-build-order.patch +BuildRequires: libqtcontacts-tracker-extensions-devel +BuildRequires: pkgconfig(QtCore) >= 4.7.0 +BuildRequires: pkgconfig(QtContacts) +BuildRequires: pkgconfig(QtSparql) +BuildRequires: pkgconfig(tracker-sparql-0.10) + +%description +Library for accessing the communications (IM, SMS and call) history database. + +#package tests +#Summary: Unit Test files for libcommhistory +#Group: Development/Libraries + +#description tests +#Unit Test files for libcommhistory + +%package tools +Summary: Command line tools for libcommhistory +Group: Communications/Telephony and IM +Requires: %{name} = %{version}-%{release} + +%description tools +Command line tools for the commhistory library. + +%package devel +Summary: Development files for libcommhistory +Group: Development/Libraries +Requires: %{name} = %{version}-%{release} + +%description devel +Headers and static libraries for the commhistory library. + + +%package doc +Summary: Documentation for libcommhistory +Group: Documentation + +%description doc +Documentation for libcommhistory + + +%prep +%setup -q -n %{name}-%{version} + +%patch0 -p1 + +%build +unset LD_AS_NEEDED +%qmake +make %{?jobs:-j%jobs} + +%install +rm -rf %{buildroot} +%qmake_install + +%post +/sbin/ldconfig + +%postun +/sbin/ldconfig + +%files +%defattr(-,root,root,-) +%{_libdir}/lib*.so* + +%files tools +%defattr(-,root,root,-) +%{_bindir}/commhistory-tool + +#files tests +#defattr(-,root,root,-) +%exclude %{_datadir}/libcommhistory-performance-tests/* +%exclude %{_datadir}/libcommhistory-tests/* + +%files devel +%defattr(-,root,root,-) +%{_libdir}/libcommhistory.a +%{_libdir}/pkgconfig/commhistory.pc +%{_includedir}/CommHistory/* + +%files doc +%defattr(-,root,root,-) +%{_datadir}/doc/libcommhistory/* + other changes: -------------- ++++++ libcommhistory-1.3.12.6-fix-shared-static-lib-build-order.patch (new) --- libcommhistory-1.3.12.6-fix-shared-static-lib-build-order.patch +++ libcommhistory-1.3.12.6-fix-shared-static-lib-build-order.patch @@ -0,0 +1,9 @@ +diff -uNr libcommhistory-1.3.13.1/src/src.pro libcommhistory-1.3.13.1.p1/src/src.pro +--- libcommhistory-1.3.13.1/src/src.pro 2012-07-30 15:40:53.000000000 +0000 ++++ libcommhistory-1.3.13.1.p1/src/src.pro 2012-07-31 14:30:11.352421528 +0000 +@@ -21,4 +21,5 @@ + ############################################################################### + + TEMPLATE = subdirs ++CONFIG += ordered + SUBDIRS = shared.pro static.pro ++++++ libcommhistory-1.3.12.6.tar.gz (new) submit: home:tswindell:CE:Apps / commhistory-daemon -> CE:MW:MTF / commhistory-daemon changes files: -------------- ++++++ new changes file: --- commhistory-daemon.changes +++ commhistory-daemon.changes @@ -0,0 +1,3 @@ +* Tue Jul 31 2012 Tom Swindell <[email protected]> - 0.3.2 +- Updated sources from git, for libcommhistory and commhistory-daemon packages. + new: ---- commhistory-daemon-0.3.2-fix-ignored-return-with-warn_unused_result.patch commhistory-daemon-0.3.2.tar.gz commhistory-daemon.changes commhistory-daemon.spec spec files: ----------- ++++++ new spec file: --- commhistory-daemon.spec +++ commhistory-daemon.spec @@ -0,0 +1,63 @@ +Name: commhistory-daemon +Summary: Communications event history database daemon +Version: 0.3.2 +Release: 1 +Group: Communications/Telephony and IM +License: LGPL +URL: http://gitorious.org/commhistory/commhistory-daemon +Source0: %{name}-%{version}.tar.gz +Patch0: commhistory-daemon-0.3.2-fix-ignored-return-with-warn_unused_result.patch +BuildRequires: pkgconfig(QtCore) >= 4.7.0 +BuildRequires: pkgconfig(QtContacts) +BuildRequires: pkgconfig(commhistory) +BuildRequires: pkgconfig(contextsubscriber-1.0) +BuildRequires: pkgconfig(TelepathyQt4) +BuildRequires: pkgconfig(meegotouch) +BuildRequires: qmsystem-devel +BuildRequires: python + +#package tests +#Summary: Unit tests for commhistory-daemon +#Group: Development/Libraries + +#description tests +#Unit tests for commhistory-daemon + +%description +Daemon for logging communications (IM, SMS and call) in history database. + +%prep +%setup -q -n %{name}-%{version} + +%patch0 -p1 + +%build +unset LD_AS_NEEDED +%qmake +make %{?jobs:-j%jobs} + +%install +rm -rf %{buildroot} +%qmake_install + +%post +/sbin/ldconfig + +%postun +/sbin/ldconfig + +%files +%defattr(-,root,root,-) +%{_bindir}/commhistoryd +%{_bindir}/commhistoryd.qm +%{_datadir}/dbus-1/services/com.nokia.CommHistory.service +%{_datadir}/dbus-1/services/org.freedesktop.Telepathy.Client.CommHistory.service +%{_datadir}/l10n/meegotouch/commhistoryd.qm +%{_datadir}/doc/commhistory-daemon-l10n-engineering-english/commhistoryd.ts +%{_datadir}/meegotouch/notifications/eventtypes/* +%{_datadir}/telepathy/clients/CommHistory.client + +#files tests +#defattr(-,root,root,-) +%exclude %{_datadir}/commhistory-daemon-tests/* + other changes: -------------- ++++++ commhistory-daemon-0.3.2-fix-ignored-return-with-warn_unused_result.patch (new) --- commhistory-daemon-0.3.2-fix-ignored-return-with-warn_unused_result.patch +++ commhistory-daemon-0.3.2-fix-ignored-return-with-warn_unused_result.patch @@ -0,0 +1,15 @@ +diff -uNr commhistory-daemon-0.3.3~067858b/src/main.cpp commhistory-daemon-0.3.3~067858b.p1/src/main.cpp +--- commhistory-daemon-0.3.3~067858b/src/main.cpp 2012-07-30 15:46:52.000000000 +0000 ++++ commhistory-daemon-0.3.3~067858b.p1/src/main.cpp 2012-07-31 16:44:45.648204849 +0000 +@@ -88,7 +88,10 @@ + void termSignalHandler(int) + { + char a = 1; +- ::write(sigtermFd[0], &a, sizeof(a)); ++ if(write(sigtermFd[0], &a, sizeof(a)) < 1) ++ { ++ qWarning("Failed to handle term signal."); ++ } + } + + void setupSigtermHandler() ++++++ commhistory-daemon-0.3.2.tar.gz (new)
