I have made the following changes intended for : CE:UX:MTF / lipstick Please review and accept or decline. BOSS has already run some checks on this request. See the "Messages from BOSS" section below.
https://build.pub.meego.com//request/show/7385 Thank You, vesku [This message was auto-generated] --- Request # 7385: Messages from BOSS: State: review at 2012-11-15T17:24:25 by bossbot Reviews: accepted by bossbot : Prechecks succeeded. new for CE-maintainers : Please replace this text with a review and approve/reject the review (not the SR). BOSS will take care of the rest Changes: submit: home:vesku:branches:CE:UX:MTF / lipstick -> CE:UX:MTF / lipstick changes files: -------------- --- lipstick.changes +++ lipstick.changes @@ -0,0 +1,4 @@ +* Thu Nov 15 2012 Vesa-Matti Hartikainen <[email protected]> - 0.4.12 +- Do not enable debug for notifications by default +- expose xeventlistner and xatomcache + old: ---- lipstick-0.4.11.tar.bz2 new: ---- lipstick-0.4.12.tar.gz spec files: ----------- --- lipstick.spec +++ lipstick.spec @@ -9,12 +9,12 @@ # << macros Summary: QML toolkit for homescreen creation -Version: 0.4.11 +Version: 0.4.12 Release: 1 Group: System/Libraries License: LGPLv2.1 URL: http://github.com/nemomobile/lipstick -Source0: %{name}-%{version}.tar.bz2 +Source0: %{name}-%{version}.tar.gz Source100: lipstick.yaml Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig @@ -62,7 +62,7 @@ %prep -%setup -q -n %{name} +%setup -q -n %{name}-%{version} # >> setup # << setup other changes: -------------- ++++++ lipstick-0.4.11.tar.bz2 -> lipstick-0.4.12.tar.gz --- .gitignore +++ .gitignore @@ -0,0 +1,18 @@ +Makefile +*.o +*gen_*.h +*gen_*.cpp +*gen_*.o +*moc_*.h +*moc_*.cpp +*moc_*.o +*~ +*.log +*.log.xml +*.gcno +*.gcda +*.pro.user +configure-stamp +build-stamp +.project +.cproject --- plugin/.gitignore +++ plugin/.gitignore @@ -0,0 +1 @@ +liblipstickplugin.so --- src/.gitignore +++ src/.gitignore @@ -0,0 +1,2 @@ +liblipstick.* +pkgconfig --- src/notifications/.gitignore +++ src/notifications/.gitignore @@ -0,0 +1 @@ +notificationmanageradaptor.* --- src/src.pro +++ src/src.pro @@ -4,7 +4,7 @@ TARGET = lipstick VERSION = 0.4.11 -DEFINES += LIPSTICK_BUILD_LIBRARY DEBUG_NOTIFICATIONS VERSION=\\\"$$VERSION\\\" +DEFINES += LIPSTICK_BUILD_LIBRARY VERSION=\\\"$$VERSION\\\" CONFIG += qt INSTALLS = target @@ -27,7 +27,9 @@ notifications/notificationmanager.h \ notifications/notification.h \ notifications/notificationlistmodel.h \ - notifications/notificationpreviewpresenter.h + notifications/notificationpreviewpresenter.h \ + xtools/xeventlistener.h \ + xtools/xatomcache.h INSTALLS += publicheaderfiles publicheaderfiles.files = $$PUBLICHEADERS @@ -38,8 +40,6 @@ utilities/qobjectlistmodel.h \ xtools/homewindowmonitor.h \ xtools/windowmonitor.h \ - xtools/xeventlistener.h \ - xtools/xatomcache.h \ xtools/xwindowmanager.h \ xtools/x11wrapper.h \ lipstickdbusinterface.h \ --- src/xtools/xatomcache.h +++ src/xtools/xatomcache.h @@ -18,10 +18,13 @@ #ifndef ATOMCACHE_H #define ATOMCACHE_H +#include <QByteArray> #include <X11/Xlib.h> #include <X11/Xutil.h> -class AtomCache +#include "lipstickglobal.h" + +class LIPSTICK_EXPORT AtomCache { public: static Atom atom(const QByteArray &atom); --- src/xtools/xeventlistener.h +++ src/xtools/xeventlistener.h @@ -14,13 +14,14 @@ #define XEVENTLISTENER_H_ #include <X11/Xlib.h> +#include "lipstickglobal.h" /*! * An interface for listening to X events. * Objects of this class receive X events throughout their lifecycle as the events * arrive. */ -class XEventListener +class LIPSTICK_EXPORT XEventListener { public: /*! --- tests/ut_categorydefinitionstore/.gitignore +++ tests/ut_categorydefinitionstore/.gitignore @@ -0,0 +1 @@ +ut_categorydefinitionstore --- tests/ut_lipstickdbusinterface/.gitignore +++ tests/ut_lipstickdbusinterface/.gitignore @@ -0,0 +1 @@ +ut_lipstickdbusinterface --- tests/ut_lipsticksettings/.gitignore +++ tests/ut_lipsticksettings/.gitignore @@ -0,0 +1 @@ +ut_lipsticksettings --- tests/ut_notification/.gitignore +++ tests/ut_notification/.gitignore @@ -0,0 +1 @@ +ut_notification --- tests/ut_notificationlistmodel/.gitignore +++ tests/ut_notificationlistmodel/.gitignore @@ -0,0 +1 @@ +ut_notificationlistmodel --- tests/ut_notificationmanager/.gitignore +++ tests/ut_notificationmanager/.gitignore @@ -0,0 +1 @@ +ut_notificationmanager --- tests/ut_notificationpreviewpresenter/.gitignore +++ tests/ut_notificationpreviewpresenter/.gitignore @@ -0,0 +1 @@ +ut_notificationpreviewpresenter --- tools/notificationtool/.gitignore +++ tools/notificationtool/.gitignore @@ -0,0 +1,2 @@ +notificationmanagerproxy.* +notificationtool ++++++ lipstick.yaml --- lipstick.yaml +++ lipstick.yaml @@ -1,12 +1,12 @@ Name: lipstick Summary: QML toolkit for homescreen creation -Version: 0.4.11 +Version: 0.4.12 Release: 1 Group: System/Libraries License: LGPLv2.1 URL: http://github.com/nemomobile/lipstick Sources: - - "%{name}-%{version}.tar.bz2" + - "%{name}-%{version}.tar.gz" Description: A QML toolkit for homescreen creation Builder: qmake PkgConfigBR:
