I have made the following changes intended for : CE:MW:Shared / nemo-qml-plugin-messages-internal
Please review and accept or decline. BOSS has already run some checks on this request. See the "Messages from BOSS" section below. https://build.pub.meego.com//request/show/7734 Thank You, John Brooks [This message was auto-generated] --- Request # 7734: Messages from BOSS: State: review at 2013-01-25T07:34:05 by bossbot Reviews: accepted by bossbot : Prechecks succeeded. new for CE-maintainers : Please replace this text with a review and approve/reject the review (not the SR). BOSS will take care of the rest Changes: submit: home:special:branches:CE:MW:Shared / nemo-qml-plugin-messages-internal -> CE:MW:Shared / nemo-qml-plugin-messages-internal changes files: -------------- --- nemo-qml-plugin-messages-internal.changes +++ nemo-qml-plugin-messages-internal.changes @@ -0,0 +1,3 @@ +* Mon Jan 21 2013 John Brooks <[email protected]> - 0.0.2 +- Add GroupManager::ready property (contributes to NEMO#476) + old: ---- nemo-qml-plugin-messages-0.0.1.tar.bz2 new: ---- nemo-qml-plugin-messages-0.0.2.tar.bz2 spec files: ----------- --- nemo-qml-plugin-messages-internal.spec +++ nemo-qml-plugin-messages-internal.spec @@ -9,7 +9,7 @@ # << macros Summary: QML plugin for internal messages functionality -Version: 0.0.1 +Version: 0.0.2 Release: 1 Group: System/Libraries License: BSD other changes: -------------- ++++++ nemo-qml-plugin-messages-0.0.1.tar.bz2 -> nemo-qml-plugin-messages-0.0.2.tar.bz2 --- src/groupmanager.cpp +++ src/groupmanager.cpp @@ -50,6 +50,7 @@ modelThread->start(); mGroupModel = new CommHistory::GroupModel(this); + connect(mGroupModel, SIGNAL(modelReady(bool)), SIGNAL(readyChanged())); mGroupModel->setBackgroundThread(modelThread); mGroupModel->getGroups(); } --- src/groupmanager.h +++ src/groupmanager.h @@ -53,6 +53,9 @@ Q_PROPERTY(QObject* groupModel READ groupModel CONSTANT) CommHistory::GroupModel *groupModel() const { return mGroupModel; } + Q_PROPERTY(bool ready READ isReady NOTIFY readyChanged) + bool isReady() const { return mGroupModel->isReady(); } + /* Get a conversation by commhistory group ID, creating it if necessary. * A telepathy channel will be established if none exists already. */ Q_INVOKABLE ConversationChannel *getConversationById(int groupid); @@ -64,6 +67,9 @@ CommHistory::Group groupFromUid(const QString &localUid, const QString &remoteUid); CommHistory::Group groupFromId(int groupid); +signals: + void readyChanged(); + private slots: void groupDestroyed(QObject *obj); ++++++ nemo-qml-plugin-messages-internal.yaml --- nemo-qml-plugin-messages-internal.yaml +++ nemo-qml-plugin-messages-internal.yaml @@ -2,7 +2,7 @@ Summary: QML plugin for internal messages functionality Group: System/Libraries Description: QML plugin for internal messages functionality in Nemo -Version: 0.0.1 +Version: 0.0.2 Release: 1 Sources: - "nemo-qml-plugin-messages-%{version}.tar.bz2"
