I have made the following changes intended for : CE:MW:Shared / libqtsparql-tracker-extensions
Please review and accept or decline. BOSS has already run some checks on this request. See the "Messages from BOSS" section below. https://build.pub.meego.com//request/show/8380 Thank You, martyone [This message was auto-generated] --- Request # 8380: Messages from BOSS: State: review at 2013-03-07T08:58:15 by bossbot Reviews: accepted by bossbot : Prechecks succeeded. new for CE-maintainers : Please replace this text with a review and approve/reject the review (not the SR). BOSS will take care of the rest Changes: submit: home:martyone:branches:CE:MW:Shared / libqtsparql-tracker-extensions -> CE:MW:Shared / libqtsparql-tracker-extensions changes files: -------------- --- libqtsparql-tracker-extensions.changes +++ libqtsparql-tracker-extensions.changes @@ -0,0 +1,6 @@ +* Thu Mar 07 2013 Martin Kampas <[email protected]> - 0.0.7 +- Fix NEMO#533: libqtsparql-tracker-extensions-tests: tests.xml does not validate and test case fails +- Add libqtsparql-tracker-extensions-tests-fix-duplicate-case-name.patch +- Add libqtsparql-tracker-extensions-tests-do-not-su.patch +- Add libqtsparql-tracker-extensions-tests-do-not-hardcode-paths.patch + new: ---- libqtsparql-tracker-extensions-tests-do-not-hardcode-paths.patch libqtsparql-tracker-extensions-tests-do-not-su.patch libqtsparql-tracker-extensions-tests-fix-duplicate-case-name.patch spec files: ----------- --- libqtsparql-tracker-extensions.spec +++ libqtsparql-tracker-extensions.spec @@ -6,6 +6,9 @@ License: LGPLv2 URL: http://gitorious.com/+maemo-af-developers/maemo-af/libqtsparql-tracker Source0: %{name}-%{version}.tar.gz +Patch0: libqtsparql-tracker-extensions-tests-fix-duplicate-case-name.patch +Patch1: libqtsparql-tracker-extensions-tests-do-not-su.patch +Patch2: libqtsparql-tracker-extensions-tests-do-not-hardcode-paths.patch BuildRequires: autoconf BuildRequires: automake BuildRequires: doxygen @@ -46,6 +49,10 @@ %prep %setup -q -n %{name}-%{version} +%patch0 -p1 +%patch1 -p1 +%patch2 -p1 + %build ./autogen.sh ./configure -prefix /usr other changes: -------------- ++++++ libqtsparql-tracker-extensions-tests-do-not-hardcode-paths.patch (new) --- libqtsparql-tracker-extensions-tests-do-not-hardcode-paths.patch +++ libqtsparql-tracker-extensions-tests-do-not-hardcode-paths.patch @@ -0,0 +1,13 @@ +Index: libqtsparql-tracker-extensions-0.0.7/tests/extensions/tests.xml +=================================================================== +--- libqtsparql-tracker-extensions-0.0.7.orig/tests/extensions/tests.xml ++++ libqtsparql-tracker-extensions-0.0.7/tests/extensions/tests.xml +@@ -41,7 +41,7 @@ + </environments> + + <get> +- <file>/home/user/.local/share/tracker/tracker-store.log</file> ++ <file>${XDG_DATA_HOME:-${HOME}/.local/share}/tracker/tracker-store.log</file> + </get> + + </set> ++++++ libqtsparql-tracker-extensions-tests-do-not-su.patch (new) --- libqtsparql-tracker-extensions-tests-do-not-su.patch +++ libqtsparql-tracker-extensions-tests-do-not-su.patch @@ -0,0 +1,49 @@ +Index: libqtsparql-tracker-extensions-0.0.7/tests/extensions/tests.xml +=================================================================== +--- libqtsparql-tracker-extensions-0.0.7.orig/tests/extensions/tests.xml ++++ libqtsparql-tracker-extensions-0.0.7/tests/extensions/tests.xml +@@ -4,35 +4,35 @@ + <set name="qtsparql-tracker" description="Tests for QtSparqlTracker"> + <pre_steps> + <step> +- su - user -c "tracker-sparql -u -f /usr/share/libqtsparql-tracker-extensions-tests/clean-data.query"; ++ tracker-sparql -u -f /usr/share/libqtsparql-tracker-extensions-tests/clean-data.query + </step> + </pre_steps> + <case name="test-contact-added" description="Notifying insertions"> + <step> +- su - user -c "tracker-sparql -u -f /usr/share/libqtsparql-tracker-extensions-tests/clean-data.query; +- /usr/lib/libqtsparql-tracker-extensions-tests/tst_tracker_signals contact_added" ++ tracker-sparql -u -f /usr/share/libqtsparql-tracker-extensions-tests/clean-data.query ++ /usr/lib/libqtsparql-tracker-extensions-tests/tst_tracker_signals contact_added + </step> + </case> + <case name="test-contact-removed" description="Notifying deletions"> + <step> +- su - user -c "tracker-sparql -u -f /usr/share/libqtsparql-tracker-extensions-tests/clean-data.query; +- /usr/lib/libqtsparql-tracker-extensions-tests/tst_tracker_signals contact_deleted" ++ tracker-sparql -u -f /usr/share/libqtsparql-tracker-extensions-tests/clean-data.query ++ /usr/lib/libqtsparql-tracker-extensions-tests/tst_tracker_signals contact_deleted + </step> + </case> + <case name="test-contact-removed-2" description="Notifying deletions"> + <step> +- su - user -c "tracker-sparql -u -f /usr/share/libqtsparql-tracker-extensions-tests/clean-data.query; +- /usr/lib/libqtsparql-tracker-extensions-tests/tst_tracker_signals recreateChangeNotifier" ++ tracker-sparql -u -f /usr/share/libqtsparql-tracker-extensions-tests/clean-data.query ++ /usr/lib/libqtsparql-tracker-extensions-tests/tst_tracker_signals recreateChangeNotifier + </step> + </case> + <case name="test-sync" description="Tracker Sync"> + <step> +- su - user -c "/usr/lib/libqtsparql-tracker-extensions-tests/tst_tracker_sync" ++ /usr/lib/libqtsparql-tracker-extensions-tests/tst_tracker_sync + </step> + </case> + <post_steps> + <step> +- su - user -c "tracker-sparql -u -f /usr/share/libqtsparql-tracker-extensions-tests/clean-data.query" ++ tracker-sparql -u -f /usr/share/libqtsparql-tracker-extensions-tests/clean-data.query + </step> + </post_steps> + ++++++ libqtsparql-tracker-extensions-tests-fix-duplicate-case-name.patch (new) --- libqtsparql-tracker-extensions-tests-fix-duplicate-case-name.patch +++ libqtsparql-tracker-extensions-tests-fix-duplicate-case-name.patch @@ -0,0 +1,13 @@ +Index: libqtsparql-tracker-extensions-0.0.7/tests/extensions/tests.xml +=================================================================== +--- libqtsparql-tracker-extensions-0.0.7.orig/tests/extensions/tests.xml ++++ libqtsparql-tracker-extensions-0.0.7/tests/extensions/tests.xml +@@ -19,7 +19,7 @@ + /usr/lib/libqtsparql-tracker-extensions-tests/tst_tracker_signals contact_deleted" + </step> + </case> +- <case name="test-contact-removed" description="Notifying deletions"> ++ <case name="test-contact-removed-2" description="Notifying deletions"> + <step> + su - user -c "tracker-sparql -u -f /usr/share/libqtsparql-tracker-extensions-tests/clean-data.query; + /usr/lib/libqtsparql-tracker-extensions-tests/tst_tracker_signals recreateChangeNotifier"
