I have made the following changes intended for : CE:Apps / qmlmail Please review and accept or decline. BOSS has already run some checks on this request. See the "Messages from BOSS" section below.
https://build.pub.meego.com//request/show/8394 Thank You, Robin Burchell [This message was auto-generated] --- Request # 8394: Messages from BOSS: State: review at 2013-03-13T18:26:03 by bossbot Reviews: accepted by bossbot : Prechecks succeeded. new for CE-maintainers : Please replace this text with a review and approve/reject the review (not the SR). BOSS will take care of the rest Changes: submit: home:w00t:branches:CE:Apps / qmlmail -> CE:Apps / qmlmail changes files: -------------- --- qmlmail.changes +++ qmlmail.changes @@ -0,0 +1,4 @@ +* Fri Mar 08 2013 Robin Burchell <[email protected]> - 0.0.7 +- Remove non-functional menus (from Ruediger Gad) +- Use ListDelegate in lists (from Robin) + old: ---- qmlmail-0.0.6.tar.bz2 new: ---- qmlmail-0.0.7.tar.bz2 spec files: ----------- --- qmlmail.spec +++ qmlmail.spec @@ -9,7 +9,7 @@ # << macros Summary: Mail application for nemo -Version: 0.0.6 +Version: 0.0.7 Release: 1 Group: Applications/System License: GPLv2 other changes: -------------- ++++++ qmlmail-0.0.6.tar.bz2 -> qmlmail-0.0.7.tar.bz2 --- src/qml/AccountPage.qml +++ src/qml/AccountPage.qml @@ -49,10 +49,10 @@ onCurrentIndexChanged: container.topicTriggered(currentIndex) - delegate: MouseArea { + delegate: ListDelegate { id: accountItem - width: parent.width - height: UiConstants.ListItemHeightDefault + x: UiConstants.DefaultMargin + width: ListView.view.width - UiConstants.DefaultMargin * 2 Component.onCompleted: { if (index == 0) { @@ -61,16 +61,7 @@ } } - Label { - height: parent.height - anchors.left: parent.left - anchors.leftMargin: UiConstants.DefaultMargin - anchors.right: unreadImage.left - anchors.rightMargin: UiConstants.DefaultMargin - verticalAlignment: Text.AlignVCenter - text: emailAddress + " - " + displayName //i18n ok - elide: Text.ElideRight - } + titleText: emailAddress + " - " + displayName //i18n ok CountBubble { id: unreadImage @@ -112,6 +103,5 @@ window.refreshInProgress = true; } } } - ToolIcon { iconId: "toolbar-view-menu" ; onClicked: colorMenu.open(); } } } --- src/qml/FolderListView.qml +++ src/qml/FolderListView.qml @@ -8,6 +8,7 @@ import QtQuick 1.1 import com.nokia.meego 1.2 +import com.nokia.extras 1.1 import org.nemomobile.email 0.1 Page { @@ -122,35 +123,14 @@ } } - delegate: MouseArea { + delegate: ListDelegate { id: dinstance - height: UiConstants.ListItemHeightDefault - width: parent.width + x: UiConstants.DefaultMargin + width: ListView.view.width - UiConstants.DefaultMargin * 2 - Label { - id: senderText - anchors.left: parent.left - anchors.right: parent.right - anchors.leftMargin: UiConstants.DefaultMargin - anchors.rightMargin: UiConstants.DefaultMargin - height: UiConstants.ListItemHeightDefault / 2 - text: senderDisplayName != "" ? senderDisplayName : senderEmailAddress - font.bold: readStatus ? false : true - anchors.bottomMargin: 4 - elide: Text.ElideRight - } - - Label { - id: subjectText - text: subject - anchors.top: senderText.bottom - anchors.left: parent.left - anchors.right: parent.right - anchors.leftMargin: UiConstants.DefaultMargin - anchors.rightMargin: UiConstants.DefaultMargin - height: theme.listBackgroundPixelHeightTwo / 2 - elide: Text.ElideRight - } + titleText: senderDisplayName != "" ? senderDisplayName : senderEmailAddress + titleWeight: readStatus ? Font.Normal : Font.Bold + subtitleText: subject // TODO: attachments icon, logic: // opacity: numberOfAttachments ? 1 : 0 @@ -232,6 +212,5 @@ window.refreshInProgress = true; } } } - ToolIcon { iconId: "toolbar-view-menu" ; onClicked: colorMenu.open(); } } } ++++++ qmlmail.yaml --- qmlmail.yaml +++ qmlmail.yaml @@ -1,6 +1,6 @@ Name: qmlmail Summary: Mail application for nemo -Version: 0.0.6 +Version: 0.0.7 Release: 1 Group: Applications/System License: GPLv2
