I have made the following changes intended for : nemo:devel:mw / libqofono
Please review and accept or decline. BOSS has already run some checks on this request. See the "Messages from BOSS" section below. https://build.merproject.org//request/show/196 Thank You, Lorn Potter [This message was auto-generated] --- Request # 196: Messages from BOSS: State: review at 2013-04-10T03:19:52 by cibot Reviews: accepted by cibot : Prechecks succeeded. new for nemo:devel:mw : Please replace this text with a review and approve/reject the review (not the SR). BOSS will take care of the rest Changes: submit: home:lpotter:branches:nemo:devel:mw / libqofono -> nemo:devel:mw / libqofono changes files: -------------- --- libqofono.changes +++ libqofono.changes @@ -0,0 +1,3 @@ +* Wed Apr 10 2013 Lorn Potter <[email protected]> - 0.2 +- fixed removeContext function + old: ---- libqofono-0.1.tar.bz2 new: ---- libqofono-0.2.tar.bz2 spec files: ----------- --- libqofono.spec +++ libqofono.spec @@ -9,8 +9,8 @@ # << macros Summary: A library of Qt bindings for ofono -Version: 0.1 -Release: 3 +Version: 0.2 +Release: 1 Group: System/Libraries License: LGPLv2.1 URL: https://github.com/nemomobile/libqofono other changes: -------------- ++++++ libqofono-0.1.tar.bz2 -> libqofono-0.2.tar.bz2 --- makedist +++ makedist @@ -0,0 +1,53 @@ +#!/bin/bash + + + + +# Determine project name based on current directory +#PROJECT=$(basename $PWD) +PROJECT=libqofono + +# NOTE: Don't like this? Then uncomment one of the following as appropriate +# +# Just set it explictly to whatever you like: +# PROJECT=libseaside +# +# Parse it from any Qt *.pro or *.pri files in CWD: +# PROJECT=$(grep -E "TARGET ?= ?" *.pr[io]|cut -d' ' -f3) + +while getopts ht: o +do case $o in + h) head=1;; + t) TAG="$OPTARG";; + ?) printf >&2 "Usage: $0 [-h] [-t TAG]\n" + exit 2;; + esac +done + +# Grab most recent tag from git unless TAG is set +if [ -z "$TAG" ] ; then + TAG=$(git describe --tags --abbrev=0) +fi + +# Parse out just the version number +#PARTS=(${TAG//-/ }) +#VERSION=${PARTS[1]} +VERSION=${TAG} + +# Set name of toplevel directory for the archive +PREFIX="${PROJECT}-${VERSION}/" + +# Set name of resulting release archive file +ARCHIVE=${PROJECT}-${VERSION}.tar.bz2 + +[ -e ${ARCHIVE} ] && rm -rf ${ARCHIVE} && echo "Removed: ${ARCHIVE}" + +if [ ! -z "$head" ] ; then + TAG="HEAD" +fi + +git archive --format=tar --prefix=${PREFIX} $TAG | bzip2 -c -- > ${ARCHIVE} && { + echo "Created: ${ARCHIVE}" +} || { + echo "Creation of release archive ${ARCHIVE} failed. Reason unknown." +} --- rpm/libqofono.spec +++ rpm/libqofono.spec @@ -9,12 +9,12 @@ # << macros Summary: A library of Qt bindings for ofono -Version: 0.1 -Release: 3 +Version: 0.2 +Release: 1 Group: System/Libraries License: LGPLv2.1 -URL: https://github.com/lpotter/qofono -Source0: qofono-%{version}.tar.bz2 +URL: https://github.com/nemomobile/libqofono +Source0: libqofono-%{version}.tar.bz2 Source100: libqofono.yaml Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig @@ -54,7 +54,7 @@ %prep -%setup -q -n qofono-%{version} +%setup -q -n libqofono-%{version} # >> setup # << setup --- rpm/libqofono.yaml +++ rpm/libqofono.yaml @@ -1,12 +1,12 @@ Name: libqofono Summary: A library of Qt bindings for ofono -Version: 0.1 -Release: 3 +Version: 0.2 +Release: 1 Group: System/Libraries License: LGPLv2.1 -URL: https://github.com/lpotter/qofono +URL: https://github.com/nemomobile/libqofono Sources: - - "qofono-%{version}.tar.bz2" + - "libqofono-%{version}.tar.bz2" Description: | This package contains Qt bindings for ofono cellular service interfaces. @@ -15,7 +15,7 @@ - QtDBus Configure: none Builder: qmake -SetupOptions: "-q -n qofono-%{version}" +SetupOptions: "-q -n libqofono-%{version}" Files: - "%{_libdir}/%{name}.so.*" --- src/qofonocallbarring.h +++ src/qofonocallbarring.h @@ -45,6 +45,11 @@ #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono call barring API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/call-barring-api.txt + */ class QOfonoCallBarringPrivate; class QOFONOSHARED_EXPORT QOfonoCallBarring : public QObject --- src/qofonocallforwarding.h +++ src/qofonocallforwarding.h @@ -45,6 +45,11 @@ #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono call forwarding API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/call-forwarding-api.txt + */ class QOfonoCallForwardingPrivate; class QOFONOSHARED_EXPORT QOfonoCallForwarding : public QObject --- src/qofonocallmeter.h +++ src/qofonocallmeter.h @@ -45,6 +45,11 @@ #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono call meter API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/call-meter-api.txt + */ class QOfonoCallMeterPrivate; class QOFONOSHARED_EXPORT QOfonoCallMeter : public QObject --- src/qofonocallsettings.h +++ src/qofonocallsettings.h @@ -45,6 +45,12 @@ #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono call settings API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/call-settings-api.txt + */ + class QOfonoCallSettingsPrivate; class QOFONOSHARED_EXPORT QOfonoCallSettings : public QObject { --- src/qofonocallvolume.h +++ src/qofonocallvolume.h @@ -44,6 +44,12 @@ #include <QObject> #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono call volume API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/call-volume-api.txt + */ + class QOfonoCallVolumePrivate; class QOFONOSHARED_EXPORT QOfonoCallVolume : public QObject { --- src/qofonocellbroadcast.h +++ src/qofonocellbroadcast.h @@ -45,6 +45,11 @@ #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono cell broadcast API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/cell-broadcast-api.txt + */ class QOfonoCellBroadcastPrivate; class QOFONOSHARED_EXPORT QOfonoCellBroadcast : public QObject --- src/qofonoconnectioncontext.h +++ src/qofonoconnectioncontext.h @@ -45,6 +45,11 @@ #include <QObject> #include "dbustypes.h" #include "qofono_global.h" +//! This class is used to access ofono connman context API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob;f=doc/connman-api.txt + */ class QOfonoConnectionContextPrivate; --- src/qofonoconnectionmanager.cpp +++ src/qofonoconnectionmanager.cpp @@ -246,7 +246,7 @@ void QOfonoConnectionManager::onContextRemove(const QDBusObjectPath &path) { - if (!d_ptr->contexts.contains(path.path())) + if (d_ptr->contexts.contains(path.path())) d_ptr->contexts.removeOne(path.path()); Q_EMIT contextRemoved(path.path()); Q_EMIT contextsChanged(d_ptr->contexts); --- src/qofonoconnectionmanager.h +++ src/qofonoconnectionmanager.h @@ -45,6 +45,12 @@ #include <QObject> #include "dbustypes.h" #include "qofono_global.h" +//! This class is used to access ofono connman context API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob;f=doc/connman-api.txt + */ + class QOfonoConnectionManagerPrivate; class QOFONOSHARED_EXPORT QOfonoConnectionManager : public QObject --- src/qofonomanager.h +++ src/qofonomanager.h @@ -47,6 +47,11 @@ #include "dbustypes.h" #include "qofono_global.h" +//! This class is used to access ofono connman context API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob;f=doc/manager-api.txt + */ class QOfonoManagerPrivate; class QOFONOSHARED_EXPORT QOfonoManager : public QObject --- src/qofonomessage.h +++ src/qofonomessage.h @@ -45,6 +45,12 @@ #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono message API +/*! + * oFono message API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/message-api.txt + */ + class QOfonoMessagePrivate; class QOFONOSHARED_EXPORT QOfonoMessage : public QObject { --- src/qofonomessagemanager.h +++ src/qofonomessagemanager.h @@ -45,6 +45,12 @@ #include <QDBusVariant> #include <QStringList> #include "qofono_global.h" +//! This class is used to access ofono message manager API +/*! + * oFono message manager API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/messagemanager-api.txt + */ + class QOfonoMessageManagerPrivate; class QOFONOSHARED_EXPORT QOfonoMessageManager : public QObject { --- src/qofonomessagewaiting.h +++ src/qofonomessagewaiting.h @@ -44,6 +44,12 @@ #include <QObject> #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono message waiting API +/*! + * oFono message manager API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/message-waiting-api.txt + */ + class QOfonoMessageWaitingPrivate; class QOFONOSHARED_EXPORT QOfonoMessageWaiting : public QObject { --- src/qofonomodem.h +++ src/qofonomodem.h @@ -47,6 +47,12 @@ #include "dbustypes.h" #include "qofono_global.h" +//! This class is used to access an oFono modem object and its properties +/*! + * oFono modem properties are documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/modem-api.txt + */ + class QOfonoModemPrivate; class QOFONOSHARED_EXPORT QOfonoModem : public QObject --- src/qofononetworkoperator.h +++ src/qofononetworkoperator.h @@ -46,6 +46,11 @@ #include <QDBusVariant> #include <QStringList> #include "qofono_global.h" +//! This class is used to access ofono network operator API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/network-api.txt + */ class QOfonoNetworkOperatorPrivate; class QOFONOSHARED_EXPORT QOfonoNetworkOperator : public QObject --- src/qofononetworkregistration.h +++ src/qofononetworkregistration.h @@ -46,6 +46,11 @@ #include "dbustypes.h" #include "qofono_global.h" +//! This class is used to access ofono network operator API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/network-api.txt + */ class QOfonoNetworkRegistrationPrivate; --- src/qofonophonebook.h +++ src/qofonophonebook.h @@ -44,6 +44,11 @@ #include <QObject> #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono phonebook API +/*! + * oFono phonebook API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/phonebook-api.txt + */ class QOfonoPhonebookPrivate; class QOFONOSHARED_EXPORT QOfonoPhonebook : public QObject --- src/qofonoradiosettings.h +++ src/qofonoradiosettings.h @@ -45,6 +45,11 @@ #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono radio settings API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/radio-settings-api.txt + */ class QOfonoRadioSettingsPrivate; class QOFONOSHARED_EXPORT QOfonoRadioSettings : public QObject --- src/qofonosimmanager.h +++ src/qofonosimmanager.h @@ -46,6 +46,11 @@ #include <QStringList> #include "qofono_global.h" +//! This class is used to access ofono SIM API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/sim-api.txt + */ class QOfonoSimManagerPrivate; class QOFONOSHARED_EXPORT QOfonoSimManager : public QObject --- src/qofonosmartmessaging.h +++ src/qofonosmartmessaging.h @@ -45,6 +45,12 @@ #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono cell broadcast API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/smartmessaging-api.txt + */ + class QOfonoSmartMessagingPrivate; class QOFONOSHARED_EXPORT QOfonoSmartMessaging : public QObject { --- src/qofonosmartmessagingagent.h +++ src/qofonosmartmessagingagent.h @@ -46,7 +46,11 @@ #include <QDBusAbstractAdaptor> #include "qofono_global.h" - +//! This class is used to access ofono cell broadcast API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/smartmessaging-api.txt + */ class QOfonoSmartMessagingAgentPrivate; class QOFONOSHARED_EXPORT QOfonoSmartMessagingAgent : public QObject { @@ -94,4 +98,5 @@ QOfonoSmartMessagingAgent* smartAgent; }; + #endif // QOFONOSmartMessagingAgent_H --- src/qofonosupplementaryservices.h +++ src/qofonosupplementaryservices.h @@ -44,6 +44,12 @@ #include <QObject> #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono supplementary services API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/supplementaryservices-api.txt + */ + class QOfonoSupplementaryServicesPrivate; class QOFONOSHARED_EXPORT QOfonoSupplementaryServices : public QObject { --- src/qofonotexttelephony.h +++ src/qofonotexttelephony.h @@ -44,6 +44,12 @@ #include <QObject> #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono cell broadcast API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/text-telephony-api.txt + */ + class QOfonoTextTelephonyPrivate; class QOFONOSHARED_EXPORT QOfonoTextTelephony : public QObject { --- src/qofonovoicecall.h +++ src/qofonovoicecall.h @@ -44,6 +44,12 @@ #include <QObject> #include <QDBusVariant> #include "qofono_global.h" +//! This class is used to access ofono voice call API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob;f=doc/voicecall-api.txt + */ + class QOfonoVoiceCallPrivate; class QOFONOSHARED_EXPORT QOfonoVoiceCall : public QObject { --- src/qofonovoicecallmanager.h +++ src/qofonovoicecallmanager.h @@ -45,6 +45,12 @@ #include <QDBusVariant> #include <QStringList> #include "qofono_global.h" +//! This class is used to access ofono voice call manager API +/*! + * The API is documented in + * http://git.kernel.org/?p=network/ofono/ofono.git;a=blob_plain;f=doc/voicecallmanager-api.txt + */ + class QOfonoVoiceCallManagerPrivate; class QOFONOSHARED_EXPORT QOfonoVoiceCallManager : public QObject { ++++++ libqofono.yaml --- libqofono.yaml +++ libqofono.yaml @@ -1,7 +1,7 @@ Name: libqofono Summary: A library of Qt bindings for ofono -Version: 0.1 -Release: 3 +Version: 0.2 +Release: 1 Group: System/Libraries License: LGPLv2.1 URL: https://github.com/nemomobile/libqofono
