Joe Orton wrote:
On Sat, Jan 07, 2006 at 04:57:15PM +0100, Stefan Küng wrote:
There's a small memory leak in the sspi code. If sspi auth fails, the allocated buffer isn't freed.

Thanks Stefan, I've applied this. Any other feedback on using the SSPI code? I've not heard much about it so far.

Oh yes, please drop the patch I sent yesterday.
Yes, it makes Subversion/TSVN work again when connecting to a repo hosted on a domain controller (or set up to authenticate with one), but it also 'deactivates' the sspi authentication. It would be easier to just set the define :)

I've worked out another patch for this issue and uploaded a new TSVN version to our nightly build server for people to test. I'm pretty sure it will work this time, because I searched the web for other projects which might have the same problems, and I found several of those. All have the same workaround implemented, so I did the same for neon.

I'll send the new patch as soon as I get enough responses from TSVN testers that it works correctly. But it's weekend now, so most likely not many people working on computers which are part of a domain.

Stefan

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
_______________________________________________
neon mailing list
[email protected]
http://mailman.webdav.org/mailman/listinfo/neon

Reply via email to