Hi Max, sorry for the slow response - I missed your message when I came 
back from holiday in January and only just spotted it at the weekend.

On Mon, Jan 23, 2006 at 10:31:02PM +0000, Max Bowsher wrote:
> At several points throughout ne_auth.c, potentially unaligned char[16]
> buffers are used as MD5 result output buffers.
> 
> On a platform where alignment matters, such as sparc, this can result in
> bus errors.
> 
> One solution is to declare the buffers as md5_uint32[4].
> Incidentally, it might well be a good idea to rename that type to
> ne_md5_uint32, since it is visible in a public header file.

Thanks for reporting all this.  On the trunk I've made that whole 
structure opaque to avoid exposing the type at all, and have added a 
wrapper function which does the context->ascii digest conversion.  With 
all the auth code switched to use this it will avoid the issue within 
neon (there's hardly any use of this interface outside neon).

Regards,

joe
_______________________________________________
neon mailing list
[email protected]
http://mailman.webdav.org/mailman/listinfo/neon

Reply via email to