Hi Kiyo, thanks for sending in the patch. In the future, it's easier if
you submit separate patches (preferably in diff -u format) in separate
mails for unrelated changes.
On Fri, Aug 04, 2006 at 10:12:02PM +1000, Kiyo Kelvin Lee wrote:
> One minor problem in ne_sspi_clear_context() (ne_sspi.c) which does not
> return properly.
I've applied this.
> Another strange problem (also in ne_sspi.c) is that the mssdk comes with
> vc6 does not define FreeCredentialsHandle but define
> FreeCredentialHandle instead. (note that changed from singular to plural)
I've applied this too.
> BTW, attached is a patch to make neon cleanly (no warning) compile with
> vc6, vs2003 and vs2005.
> Need to roll back the change to neon.mak if still using vc6 though.
Is there no way to make neon.mak work with all the different vintages of
compiler suite? I've also not applied the following changes:
--- src/ne_socket.c (revision 1053)
+++ src/ne_socket.c (working copy)
@@ -449,7 +449,7 @@
/* Init the fd set */
FD_ZERO(&rdfds);
do {
- FD_SET(fdno, &rdfds);
+ FD_SET((SOCKET)fdno, &rdfds);
if (tvp) {
tvp->tv_sec = secs;
tvp->tv_usec = 0;
this is not portable; SOCKET is Win32-specific.
@@ -1012,11 +1012,11 @@
{ /* Disable the Nagle algorithm; better to add write buffering
* instead of doing this. */
int flag = 1;
- setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &flag, sizeof flag);
+ setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, (const char*)&flag, sizeof
flag);
}
is this just for a warning fix? Does changing "int flag" to "const int
flag" have the same effect?
#endif
- if (raw_connect(fd, addr, htons(port))) {
+ if (raw_connect(fd, addr, htons((u_short)port))) {
set_strerror(sock, ne_errno);
ne_close(fd);
return -1;
Again, is this just to fix a warning? htons() should return a 16-bit
unsigned int of some kind, which should be fine to pass to
raw_connect().
Regards,
joe
_______________________________________________
neon mailing list
[email protected]
http://mailman.webdav.org/mailman/listinfo/neon
