Hello,

if there is no Last-Modified header in the response the modtime would be unset resulting in random values if the caller hadn't initialized it before calling.

Debate is whether ret should be set to NE_ERROR or not if the header is missing. Technically it is an error since the header is not present, still there is no errorcode sent by the server, so ret == NE_OK and modtime == -1 means that there where an OK reply from the server but no modification time set.

The culprit here seams to be Lighttpd that does not send any Last-Modified headers.

Regards, Henrik Holst, Renderplanet AB



Index: ne_basic.c
===================================================================
--- ne_basic.c    (revision 1247)
+++ ne_basic.c    (working copy)
@@ -65,7 +65,8 @@
    ret = NE_ERROR;
    } else if (value) {
        *modtime = ne_httpdate_parse(value);
-    }
+    } else
+    *modtime = -1;

    ne_request_destroy(req);

_______________________________________________
neon mailing list
[email protected]
http://mailman.webdav.org/mailman/listinfo/neon

Reply via email to