On 05/03/2010 09:31 PM, Vishesh Handa wrote: > > On Mon, May 3, 2010 at 2:55 PM, Sebastian Trüg <[email protected] > <mailto:[email protected]>> wrote: > > I am not sure about this one. > The question is: do we get a moveself and a "normal" move if we watch > both the folder in question and the parent folder. If so we want to > ignore the moveself since the "normal" move allows us to update > properly. > If not, then, yes, your patch seems correct. > Now that only needs testing. :) Or do you know the answer already? > > > I've tested it out. If a directory and its parent are being watched, and > the directory is moved the moveSelf event does *not* occur. The normal > move does occur. :-)
OK, if that is the case then I suppose your patch is correct. But better add a lengthy comment to the code explaining why we treat moveself as a delete. BTW: Congrats on commit number 1. :) Cheers, Sebastian _______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
