OK, so we only need a stopQuery() in the setQuery method, right? IMHO that is much cleaner and easier to understand than setting current query to 0.
On 03/16/2011 02:58 PM, Vishesh Handa wrote: > This patch ( now committed ) is not that useful. > > The only thing it does is sets the time elapsed when you click the "Stop > Query" button. And it removes the old code which allowed you to > automatically stop the old query if you ran a new one. > > When a query finishes execution, or is closed, it automatically deletes > itself and therefore disconnects itself from all signals and slots. > > I know the setting of 'd->m_currentQuery = 0' was not completely > obvious. But it did what it was supposed to. The query if it was still > being executed would have been deleted when more results were received > in slotNextResultReady() > > I'll either revert this patch or fix it. > > On Wed, Mar 16, 2011 at 4:37 PM, Who Knows <[email protected] > <mailto:[email protected]>> wrote: > > The previous patch affected the copyright somehow so i am sending a > new one. > > > - Smit Shah (My real name) > > _______________________________________________ > Nepomuk mailing list > [email protected] <mailto:[email protected]> > https://mail.kde.org/mailman/listinfo/nepomuk > > > > > -- > Vishesh Handa > > > > _______________________________________________ > Nepomuk mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/nepomuk _______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
