> On June 18, 2011, 10:03 a.m., Jos van den Oever wrote: > > plugins/endplugins/jpegendanalyzer.cpp, line 317 > > <http://git.reviewboard.kde.org/r/101672/diff/1/?file=24695#file24695line317> > > > > why are you removing this 'continue' statement? > >
Because I replaced it with else/if statements which IMHO is easier to read and maintain. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101672/#review3990 ----------------------------------------------------------- On June 18, 2011, 7:41 a.m., Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101672/ > ----------------------------------------------------------- > > (Updated June 18, 2011, 7:41 a.m.) > > > Review request for Nepomuk, Strigi, Jos van den Oever, and Vishesh Handa. > > > Summary > ------- > > The jpeg plugin uses nie:contentCreated for the DateTime field in EXIF data. > nie:contentCreated has a range of xsd:dateTime but so far the plugin simply > exports the value from EXIF which uses a non-standard format "YYYY:MM:DD > hh:mm:ss". So far we had a hack in Nepomuk which would convert this string to > a QDateTime. IMHO this should be done in the plugin instead. This patch does > exactly that. > > > Diffs > ----- > > plugins/endplugins/jpegendanalyzer.cpp 928fa24 > > Diff: http://git.reviewboard.kde.org/r/101672/diff > > > Testing > ------- > > Tested via xmlindexer - the created int value matches the actual value. > > > Thanks, > > Sebastian > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
