----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101759/#review4185 -----------------------------------------------------------
nepomuk/interfaces/org.kde.nepomuk.ServiceControl.xml <http://git.reviewboard.kde.org/r/101759/#comment3418> IMHO userName does not make any sense as method name. There is no user involved. Either use name() or serviceName(). nepomuk/servicestub/servicecontrol.cpp <http://git.reviewboard.kde.org/r/101759/#comment3419> Why not just use name() instead? Also it might be interesting to expose the desktopEntryName() which is the name that is used to start the service. - Sebastian On June 25, 2011, 9:54 p.m., Artem Serebriyskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101759/ > ----------------------------------------------------------- > > (Updated June 25, 2011, 9:54 p.m.) > > > Review request for Nepomuk. > > > Summary > ------- > > Add methods userName() and description() to Nepomuk Services - in object > /servicecontrol > These methods are necessary for Nepomuk Plasma dataengine, usefull for > Nepomuk System Tray, and, generally speaking, usefull for every application > that don't want to mess up with .desktop files. Because before this patch > there is no way to query name and description of running Nepomuk Service > except to find corresponding .desktop file and parse it. > > > Diffs > ----- > > nepomuk/interfaces/org.kde.nepomuk.ServiceControl.xml dd91c8f > nepomuk/servicestub/servicecontrol.h bd77324 > nepomuk/servicestub/servicecontrol.cpp 2ad4f9f > > Diff: http://git.reviewboard.kde.org/r/101759/diff > > > Testing > ------- > > Compling. Launching. > The only error discovered - qdbusviewer refused to call these methods. But > calling using python-dbus works as expected, so I think it is qdbusviewer > problem. > > > Thanks, > > Artem > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
