----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101784/#review4190 -----------------------------------------------------------
nepomuk/servicestub/servicecontrol.cpp <http://git.reviewboard.kde.org/r/101784/#comment3422> Nitpicking: space before the new parameter. nepomuk/servicestub/servicecontrol.cpp <http://git.reviewboard.kde.org/r/101784/#comment3421> Instead of writing "Error is:" please use a format like this: "Failed to start service SERVICENAME (ERROR MESSAGE)". - Sebastian On June 27, 2011, 5:49 a.m., Artem Serebriyskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101784/ > ----------------------------------------------------------- > > (Updated June 27, 2011, 5:49 a.m.) > > > Review request for Nepomuk. > > > Summary > ------- > > Now nepomuksevicestub prints errors recived from KService::createInstance. > > > Diffs > ----- > > nepomuk/servicestub/servicecontrol.cpp 2ad4f9f > > Diff: http://git.reviewboard.kde.org/r/101784/diff > > > Testing > ------- > > Compiles,working. > Doesn't really help, actually - still need to browse code to see what cause > an error. But at least now it is easier - you can grep for error message. > > > Thanks, > > Artem > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
