----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101874/#review4522 -----------------------------------------------------------
nepomuk/utils/searchwidget.h <http://git.reviewboard.kde.org/r/101874/#comment3872> please implement this as a Q_PRIVATE_SLOT instead the way the rest of the private slots are implemented. nepomuk/utils/searchwidget.cpp <http://git.reviewboard.kde.org/r/101874/#comment3873> Please match the code formatting to the rest of the code. - Sebastian On July 7, 2011, 5:26 p.m., Artem Serebriyskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101874/ > ----------------------------------------------------------- > > (Updated July 7, 2011, 5:26 p.m.) > > > Review request for Nepomuk. > > > Summary > ------- > > 1. Add currentResourceChanged signal back to SearchWidget. I think it is more > convinient, then capturing selectionChanged and quering for currentResource. > Ideologically, selection and currentIndex are different things and there can > be currentIndex without any selection. > > > Diffs > ----- > > nepomuk/utils/searchwidget.h b7dc7ea > nepomuk/utils/searchwidget.cpp 5b1648b > > Diff: http://git.reviewboard.kde.org/r/101874/diff > > > Testing > ------- > > works on my system. > > > Thanks, > > Artem > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
