> On July 31, 2011, 8:31 a.m., Volker Krause wrote: > > agents/nepomuk_contact_feeder/nepomukcontactfeeder.cpp, line 167 > > <http://git.reviewboard.kde.org/r/102084/diff/3/?file=30169#file30169line167> > > > > You changed given and family name to use "addNameX" methods, but not > > the other name parts (middle name, etc). Is this correct? > > Martin Klapetek wrote: > I think that depends on the cardinality in the ontologies, because some > properties have setFoo only for lists and some only for strings. And the > initial port used different headers, therefore the mixup. I'll fix it so it > uses setFoo methods everywhere, creating lists from strings for list-only > setters.
This is weird. nco:nameGiven has max cardinality 1. So there should only be a setNameGiven. Martin: can you generate the classes yourself now? Try omitting NAO. > On July 31, 2011, 8:31 a.m., Volker Krause wrote: > > agents/nepomuk_contact_feeder/nepomukcontactfeeder.cpp, line 381 > > <http://git.reviewboard.kde.org/r/102084/diff/3/?file=30169#file30169line381> > > > > Again a mix of addFoo/setFoo methods, is that intentional? > > Martin Klapetek wrote: > Explained above. Again nco:poBox has mc of 1... - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102084/#review5253 ----------------------------------------------------------- On July 31, 2011, 10:45 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102084/ > ----------------------------------------------------------- > > (Updated July 31, 2011, 10:45 a.m.) > > > Review request for KDEPIM, Nepomuk and Christian Mollekopf. > > > Summary > ------- > > This is the port of Akonadi's Nepomuk-Contact-Feeder to the new Nepomuk > SimpleResource API. It follows Christian Mollekopf's NepomukFeederAgent port. > > > Diffs > ----- > > agents/CMakeLists.txt f742e86 > agents/nepomuk_contact_feeder/nepomukcontactfeeder.h 1e86efb > agents/nepomuk_contact_feeder/nepomukcontactfeeder.cpp bf32ed2 > > Diff: http://git.reviewboard.kde.org/r/102084/diff > > > Testing > ------- > > Created/updated a contact in KAddressBook, looked it up in Nepomuk database, > all data were present. > > > Thanks, > > Martin > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
