> On Aug. 8, 2011, 2:33 p.m., Vishesh Handa wrote: > > nepomuk/services/storage/graphmaintainer.cpp, line 89 > > <http://git.reviewboard.kde.org/r/102214/diff/1/?file=30795#file30795line89> > > > > It's generally not advised to block a thread like this, it would be > > better to wrap the code in a function and call that after certain intervals > > using a timer. > > > > But that is generally done so that we can have an event loop in the > > thread. Do we really need an event loop over here?
Adding an event loop would be a rather pointless raise in complexity. Surely blocking the thread is not perfect but 200 ms is not a lot and the only disadvantage is that canceling might take up to 200ms. > On Aug. 8, 2011, 2:33 p.m., Vishesh Handa wrote: > > nepomuk/services/storage/graphmaintainer.cpp, line 46 > > <http://git.reviewboard.kde.org/r/102214/diff/1/?file=30795#file30795line46> > > > > Mutex perhaps? There is no need for a mutex here. We would only need a mutex if both threads wanted to write the value. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102214/#review5506 ----------------------------------------------------------- On Aug. 4, 2011, 2:43 p.m., Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102214/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2011, 2:43 p.m.) > > > Review request for Nepomuk. > > > Summary > ------- > > The new GraphMaintainer is created at startup and will slowly remove empty > graphs which are left over from the pre-DMS days. It uses a delay between > each removal operation to not impose on the user's work at all. Thus, it > takes forever to remove the graphs but that is no big deal. > > > Diffs > ----- > > nepomuk/services/storage/CMakeLists.txt 75f6fd8 > nepomuk/services/storage/graphmaintainer.h PRE-CREATION > nepomuk/services/storage/graphmaintainer.cpp PRE-CREATION > nepomuk/services/storage/repository.cpp ce0d385 > > Diff: http://git.reviewboard.kde.org/r/102214/diff > > > Testing > ------- > > Tested manually: all empty graphs removed. > > > Thanks, > > Sebastian > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
