----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102230/#review5577 -----------------------------------------------------------
After some discussion it was clear that nie:hasLogicalPart is actually the correct property and we will treat local files as IEs always. - Sebastian On Aug. 5, 2011, 8:53 p.m., Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102230/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2011, 8:53 p.m.) > > > Review request for Nepomuk and Strigi. > > > Summary > ------- > > The range of nie:hasLogicalPart is nie:InformationElement. As far as Nepomuk > is concerned any local file is only a nfo:FileDataObject by itself. Thus, > indexing m3u files fails with an invalid range error. > Now there are basically three ways to solve this: > 1. Let the indexer add the nie:InformationElement type > 2. Let Nepomuk assume every local file is a nie:InformationElement anyway > (actually this is what the file indexer already does so we might think about > doing it in the Data Management Service as well) > 3. Use nie:hasPart in the analyser. > The latter is what this patch does. But actually I would rather like to think > this through before pushing this. I cannot wrap my head around it: does the > m3u file refer to the files on disk or the information elements inside the > files? > > > Diffs > ----- > > lib/lineanalyzers/m3ustreamanalyzer.cpp dacc15a > > Diff: http://git.reviewboard.kde.org/r/102230/diff > > > Testing > ------- > > > Thanks, > > Sebastian > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
