----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102301/#review5972 -----------------------------------------------------------
nepomuk/kcm/statuswidget.cpp <http://git.reviewboard.kde.org/r/102301/#comment5279> this is weird. Why not just "setFileIndexerSuspended(m_fileIndexerService->isSuspended())"? nepomuk/kcm/statuswidget.cpp <http://git.reviewboard.kde.org/r/102301/#comment5280> My main point before was about code duplication. You should use setFileIndexerSuspended here instead of calling setText again. nepomuk/kcm/statuswidget.cpp <http://git.reviewboard.kde.org/r/102301/#comment5281> This name suggests that the file indexer will actually be suspended or resumed which is not the case. I would rather use something like "updateSuspendResumeButtonText" - Sebastian On Aug. 24, 2011, 8:17 a.m., Smit Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102301/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2011, 8:17 a.m.) > > > Review request for Nepomuk. > > > Summary > ------- > > Now you can pause or resume strigi and see the currently indexed file. > > > Diffs > ----- > > nepomuk/controller/systray.cpp 9e058f8 > nepomuk/kcm/CMakeLists.txt 313205a > nepomuk/kcm/nepomukserverkcm.cpp b7dcab9 > nepomuk/kcm/statuswidget.h 0440745 > nepomuk/kcm/statuswidget.cpp 4798d7f > nepomuk/kcm/statuswidget.ui 359ec6e > > Diff: http://git.reviewboard.kde.org/r/102301/diff > > > Testing > ------- > > paused and resume couple of times and it works perfectly. > > > Screenshots > ----------- > > See > http://git.reviewboard.kde.org/r/102301/s/223/ > see again > http://git.reviewboard.kde.org/r/102301/s/224/ > with current status > http://git.reviewboard.kde.org/r/102301/s/226/ > > http://git.reviewboard.kde.org/r/102301/s/227/ > > > Thanks, > > Smit > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
