----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102726/#review6924 -----------------------------------------------------------
You state that you tested it. However, if it worked, then only by accident, ie. because the status changed signal is also emitted if the indexer starts on another file. nepomuk/controller/systray.h <http://git.reviewboard.kde.org/r/102726/#comment6160> Maybe call it slotActiveStatusTimeout() nepomuk/controller/systray.h <http://git.reviewboard.kde.org/r/102726/#comment6159> Why do you need to remember the status? nepomuk/controller/systray.cpp <http://git.reviewboard.kde.org/r/102726/#comment6161> just call stop() on the timer. It is a no-op if the timer is not active. it makes the code cleaner. nepomuk/controller/systray.cpp <http://git.reviewboard.kde.org/r/102726/#comment6126> Just changing a member variable does not do anything. You need to call setStatus() instead. As mention above the m_newStatus variable seems pointless. - Sebastian Trueg On Sept. 29, 2011, 7:29 p.m., Smit Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102726/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2011, 7:29 p.m.) > > > Review request for Nepomuk. > > > Description > ------- > > Now that i have added a timer it should fix the rapid passive/active changes > in nepomuk system tray icon. > > > This addresses bugs Active/Non, active, controller, of, and state. > http://bugs.kde.org/show_bug.cgi?id=Active/Non > http://bugs.kde.org/show_bug.cgi?id=active > http://bugs.kde.org/show_bug.cgi?id=controller > http://bugs.kde.org/show_bug.cgi?id=of > http://bugs.kde.org/show_bug.cgi?id=state > > > Diffs > ----- > > nepomuk/controller/systray.h 06261b7 > nepomuk/controller/systray.cpp b67eb6c > > Diff: http://git.reviewboard.kde.org/r/102726/diff/diff > > > Testing > ------- > > > Thanks, > > Smit Shah > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
