----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102128/ -----------------------------------------------------------
(Updated Oct. 11, 2011, 10:11 a.m.) Review request for Nepomuk and Sebastian Trueg. Changes ------- Addressed all of Sebastian's concerns, apart from the documentation. Description ------- When SimpleResources are passed on to storeResources they are run through an identification process, so as to avoid duplicates. The resources which fail the identification process are then created. It is nice to have a mapping of the SimpleResource uris and the uris that are finally pushed in the Nepomuk Repository. I've tried for over 2 days to transfer the stupid QHash<QUrl,QUrl> over dbus. I've now given up and passed it as a QHash<QString,QString>. Diffs (updated) ----- nepomuk/interfaces/org.kde.nepomuk.DataManagement.xml a10e3a5 nepomuk/services/storage/datamanagementadaptor.h 1ab4119 nepomuk/services/fileindexer/indexer/nepomukindexwriter.cpp ce3cad7 nepomuk/services/storage/datamanagementadaptor.cpp 156d08c nepomuk/services/storage/datamanagementcommand.h 1f06fe2 nepomuk/services/storage/datamanagementmodel.h e5bbd70 nepomuk/services/storage/datamanagementmodel.cpp d429973 nepomuk/services/storage/lib/CMakeLists.txt ec33ba7 nepomuk/services/storage/lib/datamanagement.h 61ec4cc nepomuk/services/storage/lib/datamanagement.cpp 106b289 nepomuk/services/storage/lib/dbustypes.h 900e219 nepomuk/services/storage/lib/dbustypes.cpp 27fd0f4 nepomuk/services/storage/lib/simpleresourcegraph.h 69143a6 nepomuk/services/storage/lib/simpleresourcegraph.cpp 4c5b221 nepomuk/services/storage/lib/storeresourcesjob.h PRE-CREATION nepomuk/services/storage/lib/storeresourcesjob.cpp PRE-CREATION nepomuk/services/storage/test/asyncclientapitest.cpp 628c23d Diff: http://git.reviewboard.kde.org/r/102128/diff/diff Testing ------- Tested while using metadata sharing. The mappings are correctly returned. Thanks, Vishesh Handa
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
