-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102862/#review7452
-----------------------------------------------------------
Sorry, my mistake, I changed the second if (added a not) to more easily
understand the logic and I forgot to reverse it when I wrote the patch. I try
to be more careful in the future.
This is the patch adapted to original code:
<----------------->
if (!artist.empty()) {
if (performer.empty()) {
artistField = factory->performerField;
}
else {
artistField = factory->composerField;
--->>> performerField = factory->performerField;
}
}
<----------------->
My apologies.
- Ignacio Serantes
On Oct. 17, 2011, 5:07 p.m., Sebastian Trueg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102862/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2011, 5:07 p.m.)
>
>
> Review request for Nepomuk and Strigi.
>
>
> Description
> -------
>
> The Vorbis comment specs states:
>
> ARTIST: "The artist generally considered responsible for the work. In popular
> music this is usually the performing band or singer. For classical music it
> would be the composer. For an audio book it would be the author of the
> original text."
>
> PERFORMER: "The artist(s) who performed the work. In classical music this
> would be the conductor, orchestra, soloists. In an audio book it would be the
> actor who did the reading. In popular music this is typically the same as the
> ARTIST and is omitted."
>
> This patch tries to follow that suggestion by using nmm:performer and
> nmm:composer accordingly.
>
>
> Diffs
> -----
>
> lib/endanalyzers/flacendanalyzer.cpp ec885f6
> lib/throughanalyzers/oggthroughanalyzer.cpp d70f654
>
> Diff: http://git.reviewboard.kde.org/r/102862/diff/diff
>
>
> Testing
> -------
>
> Tried indexing ogg files. The result is correct.
>
>
> Thanks,
>
> Sebastian Trueg
>
>
_______________________________________________
Nepomuk mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/nepomuk
