----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103794/ -----------------------------------------------------------
(Updated Jan. 27, 2012, 10:35 a.m.) Review request for Nepomuk, Alex Fiestas and Sebastian Trueg. Changes ------- Check the mtime of the file when analyzeFile is called. I've also removed some superfluous header files. This fixes the problem. Description ------- This Filewatcher sends files for reindexing when it receives a WriteOnClose event from inotify. This event is generated whenever a file opened in write mode is closed. Even if they were no changes. Programs like Amarok and KTorrent often open the files in write mode even when they don't make any changes. Which results in reindexing of those files. For a graphical example - http://www.afiestas.org/nepomukReindexing.ogv Diffs (updated) ----- nepomuk/interfaces/org.kde.nepomuk.FileIndexer.xml 24996f3 nepomuk/services/fileindexer/fileindexer.h 7133392 nepomuk/services/fileindexer/fileindexer.cpp 093c8da nepomuk/services/fileindexer/indexcleaner.cpp f90a0e0 nepomuk/services/fileindexer/indexscheduler.h 90757ce nepomuk/services/fileindexer/indexscheduler.cpp 1690c05 nepomuk/services/fileindexer/nepomukindexer.cpp ff981e6 nepomuk/services/filewatch/nepomukfilewatch.cpp 60550c2 Diff: http://git.reviewboard.kde.org/r/103794/diff/diff Testing ------- All the tests pass, and files are no longer reindexed when the song changes in Amarok. Thanks, Vishesh Handa
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
