----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105242/#review14705 -----------------------------------------------------------
lib/endanalyzers/id3endanalyzer.cpp <http://git.reviewboard.kde.org/r/105242/#comment11611> I think you mean "genre", not "gender". :) lib/endanalyzers/id3endanalyzer.cpp <http://git.reviewboard.kde.org/r/105242/#comment11612> Would it make sense to check the value or is ot ok to just allow any string to be the genre? - Sebastian Trueg On June 13, 2012, 4:03 p.m., Ignacio Serantes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105242/ > ----------------------------------------------------------- > > (Updated June 13, 2012, 4:03 p.m.) > > > Review request for Nepomuk, Strigi and Vishesh Handa. > > > Description > ------- > > If genre is stored in a non numeric format genre is not imported. > > > Diffs > ----- > > lib/endanalyzers/id3endanalyzer.cpp d8487b5 > > Diff: http://git.reviewboard.kde.org/r/105242/diff/ > > > Testing > ------- > > Testing with and without a genre in string form. > > > Thanks, > > Ignacio Serantes > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
