----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105247/#review14743 -----------------------------------------------------------
Ship it! This is a "ship it" but with additional "more to remove" comments. libnepomukcore/resource/resourcemanager.h <http://git.reviewboard.kde.org/r/105247/#comment11638> Actually we can also remove this as it does not make sense anymore - we are using the DMS for writing now which cannot be replaced. libnepomukcore/resource/resourcemanager.h <http://git.reviewboard.kde.org/r/105247/#comment11639> Even this could be removed. And if we need method like that why not do something like: QList<Nepomuk::Resource> somethingBlocking(const Nepomuk::Query::Query& wuery); - Sebastian Trueg On June 13, 2012, 9:06 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105247/ > ----------------------------------------------------------- > > (Updated June 13, 2012, 9:06 p.m.) > > > Review request for Nepomuk. > > > Description > ------- > > Remove old code from the ResourceManager > > Lesser code is easier to understand, plus we are allowed to break > ABI and API compatibility right now! > > > Diffs > ----- > > libnepomukcore/resource/resourcemanager.h > 012cde5c684cc15bb9983ff35cc95ac03757f679 > libnepomukcore/resource/resourcemanager.cpp > f510673944c374cff99fe9cce621601b2a0e9cf2 > libnepomukcore/resource/resourcemanager_p.h > 2143642e586ff4e5d5f530b0b20340fbe7b81753 > libnepomukcore/test/resourcetest.cpp > 82e26c36436f58774b3b86fe1a25d084a65a6217 > > Diff: http://git.reviewboard.kde.org/r/105247/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
