----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105275/#review14794 -----------------------------------------------------------
This review has been submitted with commit aae24be923c0868725952e3df35b11bc76c7b4ce by Vishesh Handa to branch master. - Commit Hook On June 16, 2012, 9:53 a.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105275/ > ----------------------------------------------------------- > > (Updated June 16, 2012, 9:53 a.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > Replace manual directory iteration code with QDirIterator > > The existing code has been causing crashes since KDE 4.5, and is very > hard to maintain since no one really understands it properly. > > Funnily enough, this version detects a lot of directories that the old > code did not. Weird. > > BUG: 239842 > > > This addresses bug 239842. > http://bugs.kde.org/show_bug.cgi?id=239842 > > > Diffs > ----- > > services/filewatch/kinotify.cpp 84043e7951aed9a86075f0760410717bf525883b > > Diff: http://git.reviewboard.kde.org/r/105275/diff/ > > > Testing > ------- > > Works for me. > > 3 tests fail in the kinotify tests. However, this patch is not the cause. > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
