----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105281/#review14871 -----------------------------------------------------------
How about just removing the "init()" from the MainModel constructor? Wouldn't that be cleaner? - Sebastian Trueg On June 17, 2012, 5:30 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105281/ > ----------------------------------------------------------- > > (Updated June 17, 2012, 5:30 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > ResourceManager: Do not double initalize the NepomukMainModel > > The NepomukMainModel is initalized once when it is created and then the > second time in ResourceManager::init. > > This results in a second connection being made to nepomukstorage, and an > extra thread being spawned over there. The old thread is eventually > deleted, but the whole process is rather pointless. > > > Diffs > ----- > > libnepomukcore/resource/resourcemanager.cpp > f510673944c374cff99fe9cce621601b2a0e9cf2 > > Diff: http://git.reviewboard.kde.org/r/105281/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
