----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105362/#review15188 -----------------------------------------------------------
Ship it! The code looks good, it is tested. I cannot say much regarding your statement about the de-facto standard, I trust you here. - Sebastian Trueg On June 26, 2012, 4:59 p.m., Ignacio Serantes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105362/ > ----------------------------------------------------------- > > (Updated June 26, 2012, 4:59 p.m.) > > > Review request for Nepomuk and Strigi. > > > Description > ------- > > A minor change to use TPE2 as nmm:albumArtist to be coherent with other > formats, like flac or ogg. This change it's not following the id3 > specification, http://www.id3.org/id3v2.4.0-frames, but seems to be a "de > facto" standard: kid3, easyTag, iTunes, Windows Media Player, etc... > > > Diffs > ----- > > lib/endanalyzers/id3endanalyzer.cpp 0db3728 > > Diff: http://git.reviewboard.kde.org/r/105362/diff/ > > > Testing > ------- > > Tested with some mp3 files with none, one and two album artists using unicode > characters. > > > Thanks, > > Ignacio Serantes > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
