----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105517/#review15719 -----------------------------------------------------------
Great to see you simplifying Resource. Can't wait for your shared mem patch! :) includes/CMakeLists.txt <http://git.reviewboard.kde.org/r/105517/#comment12219> Something went wrong with the patch here. libnepomukcore/resource/resourcedata.h <http://git.reviewboard.kde.org/r/105517/#comment12217> hasType(const Types::Class& type) would be cool instead. Internally it could use property() libnepomukcore/resource/resourcedata.cpp <http://git.reviewboard.kde.org/r/105517/#comment12218> Why do you still need variable m_types when the point is to remove the special handling? - Sebastian Trueg On July 11, 2012, 8:41 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105517/ > ----------------------------------------------------------- > > (Updated July 11, 2012, 8:41 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > Remove special handling for rdf:type > > This includes storing the maintype when loading all the properties. This > simplifies the code base, and actually improves performace. > > Because the type deduction is done during load time, the relevant types > needed to be loaded into memory by Types::EntityPrivate, this increases > the load time for each resource by an order of 5x. This extra load > eventually goes down when all the required types are loaded, but it's > there. > > Also, the additional cost of infering the type each time doesn't seem to > have any performance loss. Mainly cause everything is already in memory. > > Another reason for this patch is the planned refactoring of the class > internals to use shared memory. Every extra variable in ResourceData > adds an overhead. > > > Diffs > ----- > > Info.plist.template PRE-CREATION > includes/CMakeLists.txt 4ac2d7cfcba1522eb73b432533a08b3fd1e148b3 > includes/Query/ResultIterator PRE-CREATION > libnepomukcore/CMakeLists.txt 066c8986dfa2b3150072dbd96a71caf8873cea06 > libnepomukcore/datamanagement/createresourcejob.h > 7abf51d4c9c3a4bd0c4036234dae006c7b10bfb8 > libnepomukcore/query/resultiterator.h PRE-CREATION > libnepomukcore/query/resultiterator.cpp PRE-CREATION > libnepomukcore/resource/resource.cpp > c237f44c1420929143299aab391a0f2a7709f894 > libnepomukcore/resource/resourcedata.h > 370889700cb93dbf93bc6cb4b498fab2470cafba > libnepomukcore/resource/resourcedata.cpp > 6fa262f955936637f48c81b0cce6ac9069f37167 > > Diff: http://git.reviewboard.kde.org/r/105517/diff/ > > > Testing > ------- > > Manual + Unit Testing :) > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
