> On July 25, 2012, 8:36 a.m., Sebastian Trueg wrote: > > services/storage/classandpropertytree.cpp, line 246 > > <http://git.reviewboard.kde.org/r/105705/diff/1/?file=74669#file74669line246> > > > > Below we actually check if the file exists. Does that make sense here, > > too? Or could there be calls on files that have been removed in the > > meantime?
We do eventually check if the file exists in resolveUrls, no point duplicating it. This code is getting confusing. We should eventually separate it into two models, one for all this file resolution, and conversion, and another model for doing the actual work. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105705/#review16339 ----------------------------------------------------------- On July 24, 2012, 5:57 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105705/ > ----------------------------------------------------------- > > (Updated July 24, 2012, 5:57 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > In variantListToNodeSet, make sure the urls have a scheme of file, if no > scheme has been provided. > > Special check for blank nodes used in storeResources > > > Diffs > ----- > > services/storage/classandpropertytree.cpp 4c730bf > > Diff: http://git.reviewboard.kde.org/r/105705/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
