> On July 25, 2012, 6:13 p.m., Sebastian Trueg wrote: > > I thought strigi would do this anyway. I am fine with the patch if it does > > not but down the line this is not the place for it. libstreamanalyzer > > should always add the basic fields (which again I think it does...). Could > > it be a strigi crash that results in the file not being indexed?
The problem is that strigi does this, along with a lot of other metadata, which is quite often invalid. The invalid metadata results in storeResources failing. With this patch, if the analyzers are faulty, then we at least have some basic metadata. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105730/#review16398 ----------------------------------------------------------- On July 25, 2012, 2:59 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105730/ > ----------------------------------------------------------- > > (Updated July 25, 2012, 2:59 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > If the strigi indexer fails to index the file, we index it with this new > "simple indexer" which just sets the basic properties like url, > filename and the mimetype. > > This way, file which weren't indexed, will at least still appear in some > of the search results. > > The nie:lastModifed for these files has not been set, so the > indexscheduler will still find these files, and try to index them again. > > > Diffs > ----- > > services/fileindexer/indexer/CMakeLists.txt 1a5a506 > services/fileindexer/indexer/main.cpp e3c7288 > services/fileindexer/indexer/simpleindexer.h PRE-CREATION > services/fileindexer/indexer/simpleindexer.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105730/diff/ > > > Testing > ------- > > Manually tested > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
