> On July 27, 2012, 7:42 a.m., Sebastian Trueg wrote: > > nepomuk/core/resource.cpp, line 496 > > <http://git.reviewboard.kde.org/r/105745/diff/1/?file=74914#file74914line496> > > > > I wrote a patch for that at some point but never merged it. IMHO this > > is a tricky issue since the cache does not include all inferred properties > > and probably should not. > > One possibility would be to add a parameter which allows to enabled > > inference for the property() method. > > Vishesh Handa wrote: > Why should it not include inferred properties? Cause removing/adding them > would be a problem? > > Sebastian Trueg wrote: > Well, IMO it is weird if you get the same value multiple times, it is > confusing. The first thing that wuold need filtering is the metadata display > in Dolphin.
Yup. Of course, but then we need proper filtering both ways. Another minor problem would be having to add/remove the inferenced values from the cache in the Resource class. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105745/#review16510 ----------------------------------------------------------- On July 27, 2012, 3:31 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105745/ > ----------------------------------------------------------- > > (Updated July 27, 2012, 3:31 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > The old generic icon just used to look at the string present in > nao:hasSymbol. However, that was incorrect as nao:hasSymbol has a range > of nao:Symbol, and not of a string. > > This patch results in proper icons being shown in the Nepomuk KRunner, > as it uses genericIcon to get the icon name. > > > Diffs > ----- > > nepomuk/core/resource.cpp eba3cea > > Diff: http://git.reviewboard.kde.org/r/105745/diff/ > > > Testing > ------- > > Tested manually. > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
