----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105986/ -----------------------------------------------------------
Review request for Nepomuk, Vishesh Handa and Sebastian Trueg. Description ------- This fixes https://bugs.kde.org/show_bug.cgi?id=303670 by disabling the SHA1 analyzer in strigi. I added an extra argument to nepomukindexer, --skip, which takes a comma-separated list of analyzers to not call. Then I change the invocation of nepomukindexer from the FileIndexer class so that it gets this list from a hidden option (exclude plugins) in the nepomuk config, which defaults to the SHA1 indexer. I didn't add a KCM option because a) I don't know how to do that (this is the real reason :) ), and b) I'm not sure whether it should be a "disable SHA1" checkbox, a list, or whether we need it at all. This addresses bug 303670. http://bugs.kde.org/show_bug.cgi?id=303670 Diffs ----- services/fileindexer/fileindexerconfig.h cc00922 services/fileindexer/fileindexerconfig.cpp e2265fc services/fileindexer/indexer/indexer.h dc0e98a services/fileindexer/indexer/indexer.cpp e4f1462 services/fileindexer/indexer/main.cpp a46a651 services/fileindexer/nepomukindexer.cpp 70abee0 Diff: http://git.reviewboard.kde.org/r/105986/diff/ Testing ------- Compiled, tested that nepomukindexer indeed does not call DigestEventAnalyzer with some printing. Thanks, Simeon Bird
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
