> On Aug. 15, 2012, 7:44 a.m., Sebastian Trueg wrote: > > services/fileindexer/nepomukindexer.cpp, line 62 > > <http://git.reviewboard.kde.org/r/105986/diff/4/?file=77765#file77765line62> > > > > Does this not result in "--skipDigestEventAnalyzer"? Is that what > > should be done? I would rather think it needs to be: > > args << skip << str; > > Simeon Bird wrote: > Actually it's ok; there's a space at the end of QLatin1String("--skip "). > > What I have now creates a list: > ("--skip DigestEventAnalyzer",) > and what you suggest would make: > ("--skip ", "DigestEventAnalyzer") > > The code for the second is perhaps clearer, but it splits up options that > logically remain together. > > Sebastian Trueg wrote: > I did not see the space. I think it is not very clean but would be fine > with the patch as it is. Nice work. > > Simeon Bird wrote: > Thanks! > > Simeon Bird wrote: > Actually, you were quite right. We need args << skip << str, because > KProcess escapes spaces. > With the version above, we get messages like: > > Unrecognised option 'skip DigestEventAnalyzer' from nepomukindexer. > > I'll commit a supplementary fix...
Oh, you did it already. - Simeon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105986/#review17429 ----------------------------------------------------------- On Aug. 14, 2012, 9:22 p.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105986/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2012, 9:22 p.m.) > > > Review request for Nepomuk, Vishesh Handa and Sebastian Trueg. > > > Description > ------- > > This fixes https://bugs.kde.org/show_bug.cgi?id=303670 by disabling the SHA1 > analyzer in strigi. > I added an extra argument to nepomukindexer, --skip, which takes a > comma-separated list of analyzers to not call. > Then I change the invocation of nepomukindexer from the FileIndexer class so > that it gets this list from a hidden option (exclude plugins) in the nepomuk > config, which defaults to the SHA1 indexer. > > I didn't add a KCM option because a) I don't know how to do that (this is the > real reason :) ), and b) I'm not sure whether it should be a "disable SHA1" > checkbox, a list, or whether we need it at all. > > > This addresses bug 303670. > http://bugs.kde.org/show_bug.cgi?id=303670 > > > Diffs > ----- > > services/fileindexer/fileindexerconfig.h cc00922 > services/fileindexer/fileindexerconfig.cpp e2265fc > services/fileindexer/indexer/indexer.h dc0e98a > services/fileindexer/indexer/indexer.cpp e4f1462 > services/fileindexer/indexer/main.cpp a46a651 > services/fileindexer/nepomukindexer.cpp 70abee0 > > Diff: http://git.reviewboard.kde.org/r/105986/diff/ > > > Testing > ------- > > Compiled, tested that nepomukindexer indeed does not call DigestEventAnalyzer > with some printing. > > > Thanks, > > Simeon Bird > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
