----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106274/#review18277 -----------------------------------------------------------
Ship it! I can't test it at the moment, but the change looks small and safe enough, and I trust that you have tested it, so a fast review is fine for me :-) Please create a bug report and close it with your commit to make sure that this is included in the changelog. About the merge/cherry-pick question: I have always cherry-picked in the past, but sometimes people do merge in kde-baseapps. Unfortunately, the combination of the two results in a big mess in the output of git log and qgit. Maybe we should discuss this with all projects in kde-baseapps and agree on a common workflow... - Frank Reininghaus On Aug. 30, 2012, 11:08 a.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106274/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2012, 11:08 a.m.) > > > Review request for Dolphin and Nepomuk. > > > Description > ------- > > Dolphin is a file manager, and shouldn't be concerned with non-file > resources like notes, contacts and other stuff. > > Use FileQuery instead of Query. > > This also results in a faster queries. With File Queries Nepomuk can > perform some internal optimizations. > > PS: I'd like to get this into 4.9.1, so a fast review would be nice. Also, do > we cherry pick or merge KDE/4.9 into master? > > > Diffs > ----- > > dolphin/src/panels/places/placesitemmodel.cpp 4979013 > > Diff: http://git.reviewboard.kde.org/r/106274/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
