----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106282/#review18298 -----------------------------------------------------------
After testing this out even more I've come to realize that it doesn't to seem to always work - * Virtuoso inferencing doesn't seem to be working for graph types. I don't get any results for graphs with nrl:DiscardableInstanceBase * My patch seems to apply the graph filtering for FileQueries as well as normal queries, which is unnecessary. Not shipping this into 4.9.1. Needs more testing. - Vishesh Handa On Aug. 30, 2012, 9:50 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106282/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2012, 9:50 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > The additional "?r a [ nao:userVisible "true"^^xsd:boolean ] ." slows down > the query a lot because of the massive joins in the generated SQL. It seems > better to use graph ?g { .. } ?g a nrl:InstanceBase, which would also filter > out the results. > > Additionally, the nao:userVisible trick does not work for negation terms and > lists out the classes. > > I'd like to get this into 4.9.1 if possible. Please review fast. > > > Diffs > ----- > > libnepomukcore/query/query.cpp 21b9aa3 > > Diff: http://git.reviewboard.kde.org/r/106282/diff/ > > > Testing > ------- > > Yup. Manually tested, and it fixes some of my the tests in my query tests > (still not pushed, but I can push if anyone is interested) > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
