----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106324/#review18500 -----------------------------------------------------------
services/storage/datamanagementmodel.cpp <http://git.reviewboard.kde.org/r/106324/#comment14601> Do you really remove the oldValue? - Sebastian Trueg On Sept. 4, 2012, 12:18 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106324/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2012, 12:18 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > We should inform the Resource Watcher Manager when merging resources, so > that it can inform the interested parties. > > Also added a unit test to check if the signals are being emitted. > > > Diffs > ----- > > services/storage/datamanagementmodel.cpp 69c046d > services/storage/test/qtest_dms.cpp cc4ed07 > services/storage/test/resourcewatchertest.cpp 8a38a9c > > Diff: http://git.reviewboard.kde.org/r/106324/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
