----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106474/#review19066 -----------------------------------------------------------
Ship it! Brilliant. - Sebastian Trueg On Sept. 17, 2012, 10 a.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106474/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2012, 10 a.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > Use Virtuoso's inbuilt prefix expansion instead of the NRLModel > > The NRL Model is terribly slow and consumes as high as 60% of the actual > time it takes to run some queries. Arguably, these queries were small > and virtuoso ran them quite fast. But it still is a lot of unnecessary > time spent on modifying the query. (Based on callgrind) > > Since virtuoso already needs to parse the sparql query, it seems to make > more sense to let it do the job. Plus, it cleans up our code rather > nicely. > > BUG: 304361 > > --- > > With this it is now faster to write queries purely in sparql and avoid the > Node::resourceToN3 call which is rather expensive. > > > Diffs > ----- > > services/storage/datamanagementadaptor.cpp 499fcd0 > services/storage/repository.h 63e4c5c > services/storage/repository.cpp 62b12f9 > > Diff: http://git.reviewboard.kde.org/r/106474/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
