> On Oct. 8, 2012, 2:50 p.m., Sebastian Trueg wrote: > > services/storage/classandpropertytree.cpp, line 226 > > <http://git.reviewboard.kde.org/r/106740/diff/1/?file=88500#file88500line226> > > > > no need to have this twice.
Well, there was the case when the property has no range, and when the property doesn't exist at all. Should they not be 2 separate cases? - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106740/#review20077 ----------------------------------------------------------- On Oct. 5, 2012, 3:56 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106740/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2012, 3:56 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > The extra url comparsions take approximately 50% of the time spent in > executing variantListToNodeSet. These comparisons are for special cases > and are done based on the property. > > They can be done when the tree is being created, instead of each time > this highly important function is called. > > * Caching the literal type - QVariant::Type > * Special handling for xsd:duration > * Special handling for rdfs:Literal > > > Diffs > ----- > > services/storage/classandpropertytree.h 3e3174d > services/storage/classandpropertytree.cpp 1a337b4 > > Diff: http://git.reviewboard.kde.org/r/106740/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
