> On Dec. 18, 2012, 5:10 a.m., Vishesh Handa wrote: > > cleaner/mainwindow.cpp, line 61 > > <http://git.reviewboard.kde.org/r/107793/diff/1/?file=100106#file100106line61> > > > > ?
A cosmetic thing - if start emits finished, it will set the button text to "quit", but then the caller will set it right back to "pause", when what it does is actually to quit. This sets the text to "pause" before starting, so when the job finishes, it will end up as "quit". - Simeon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107793/#review23648 ----------------------------------------------------------- On Dec. 18, 2012, 1:54 a.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107793/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2012, 1:54 a.m.) > > > Review request for Nepomuk. > > > Description > ------- > > Fix crash when using nepomukcleaner with nepomuk disabled. When nepomuk is > disabled, now just exits. > > Needs the related soprano review to actually work > > ==Unrelated== > Could I also backport 56e476cd9b995143b4ca9a67257dc7642c879841 to KDE/4.10? > > It fixes a crash, of the sort that we would probably get hundreds of bug > reports about if it were released, in a pretty uncontroversial manner, > so I committed it to master before noticing the release freeze had already > started. > > > This addresses bug 311753. > http://bugs.kde.org/show_bug.cgi?id=311753 > > > Diffs > ----- > > cleaner/jobmodel.cpp e8e9acf > cleaner/mainwindow.cpp 9b7f0c7 > > Diff: http://git.reviewboard.kde.org/r/107793/diff/ > > > Testing > ------- > > Yup, no crash! > > > Thanks, > > Simeon Bird > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
