----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107870/#review23896 -----------------------------------------------------------
Ship it! Apart from the minor nitpicks, this seems good. Perhaps you want to add your copyright on the top of the file? It is a sizable contribution. services/fileindexer/indexer/popplerextractor.cpp <http://git.reviewboard.kde.org/r/107870/#comment18228> Could you please change this to QString title = pdfDoc->info(QLatin1String("title")).trimmed(); services/fileindexer/indexer/popplerextractor.cpp <http://git.reviewboard.kde.org/r/107870/#comment18229> This line is no longer required since the title has now been trimmed services/fileindexer/indexer/popplerextractor.cpp <http://git.reviewboard.kde.org/r/107870/#comment18230> Maybe this should be case-insensitive? - Vishesh Handa On Dec. 23, 2012, 12:45 p.m., Jörg Ehrichs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107870/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2012, 12:45 p.m.) > > > Review request for Nepomuk and Vishesh Handa. > > > Description > ------- > > Extend popplerextractor with firstpage parsing > > Often the pdf metadata is not available or wrong data is added > to the title field (pdf exporter names instead of title). > > This patch adds the possibility to parse the first page for a possible > title. A possibel title is determined by the connected text with the > biggest font that was more than one character. > > > Diffs > ----- > > services/fileindexer/indexer/popplerextractor.h c7dfa50 > services/fileindexer/indexer/popplerextractor.cpp 7015195 > > Diff: http://git.reviewboard.kde.org/r/107870/diff/ > > > Testing > ------- > > tested various pdf files, title is added correctly if it was possible to find > one > > > Thanks, > > Jörg Ehrichs > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
